Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves defaults.yaml tests #362

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Improves defaults.yaml tests #362

merged 4 commits into from
Mar 9, 2022

Conversation

joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Mar 9, 2022 •
edited
Loading

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 馃敟
  • Your PR is about writing tests for already existing code :godmode:

Updates defaults.yaml tests after #361. Thanks to @sverhoeven

@joaomcteixeira joaomcteixeira added the enhancement Enhancing an existing feature of adding a new one label Mar 9, 2022
@joaomcteixeira joaomcteixeira added this to In progress in Enhancements via automation Mar 9, 2022
@joaomcteixeira joaomcteixeira self-assigned this Mar 9, 2022
@joaomcteixeira joaomcteixeira added yaml default parameters Anything related to the YAML configuration files for default parameters :godmode: labels Mar 9, 2022
@joaomcteixeira joaomcteixeira merged commit 5ca2474 into main Mar 9, 2022
Enhancements automation moved this from In progress to Done Mar 9, 2022
@joaomcteixeira joaomcteixeira deleted the recotests branch March 9, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joaomcteixeira joaomcteixeira

Labels
enhancement Enhancing an existing feature of adding a new one yaml default parameters Anything related to the YAML configuration files for default parameters
Projects
Enhancements
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joaomcteixeira