Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank capri_ss.tsv by score and sort by sortkey #537

Merged

Conversation

rvhonorato
Copy link
Member

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

@rvhonorato rvhonorato self-assigned this Aug 6, 2022
@rvhonorato rvhonorato linked an issue Aug 6, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #537 (f5cc141) into main (c4883fb) will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   74.66%   74.68%   +0.02%     
==========================================
  Files         105      105              
  Lines        6926     6932       +6     
==========================================
+ Hits         5171     5177       +6     
  Misses       1755     1755              
Impacted Files Coverage Δ
src/haddock/modules/analysis/caprieval/capri.py 80.29% <90.90%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joaomcteixeira
Copy link
Member

I am running the workflows to see if everything goes well 👍

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows have run without issues. 👍

@rvhonorato rvhonorato merged commit f87839d into main Aug 18, 2022
@rvhonorato rvhonorato deleted the 536-capri_sstsv-ranked-by-sortby-param-instead-of-score branch August 18, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

capri_ss.tsv ranked by sortby param instead of score
3 participants