Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the varia directory containing the CNS and lmod code #571

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Conversation

amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Nov 17, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

detele this line and explain your PR here

@amjjbonvin amjjbonvin added the documentation Improve docs label Nov 17, 2022
@amjjbonvin amjjbonvin self-assigned this Nov 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 73.83% // Head: 73.48% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (f785bb4) compared to base (db7d4dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   73.83%   73.48%   -0.36%     
==========================================
  Files         105      105              
  Lines        6712     6712              
==========================================
- Hits         4956     4932      -24     
- Misses       1756     1780      +24     
Impacted Files Coverage Δ
src/haddock/libs/libsubprocess.py 42.64% <0.00%> (-13.24%) ⬇️
src/haddock/modules/analysis/rmsdmatrix/rmsd.py 86.13% <0.00%> (-11.89%) ⬇️
src/haddock/libs/libparallel.py 86.56% <0.00%> (-4.48%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amjjbonvin amjjbonvin merged commit 0421b57 into main Nov 22, 2022
@amjjbonvin amjjbonvin deleted the varia branch November 22, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improve docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants