Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed in yaml files some boeleans to use lowercase for consistency #592

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Nov 30, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Corrected some yaml files that in the description of parameters were still using booleans with capitals

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 73.71% // Head: 73.71% // No change to project coverage 👍

Coverage data is based on head (b79bb20) compared to base (9a061ac).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files         107      107           
  Lines        6853     6853           
=======================================
  Hits         5052     5052           
  Misses       1801     1801           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amjjbonvin amjjbonvin merged commit 234188a into main Nov 30, 2022
@amjjbonvin amjjbonvin deleted the boeleans branch November 30, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants