Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated paths in capri_ss cli_analyse #615

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Conversation

mgiulini
Copy link
Contributor

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #613 by changing the path inside capri_ss.tsv files produced by the analyse cli

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.28 ⚠️

Comparison is base (0971f60) 73.75% compared to head (50412ae) 73.48%.

❗ Current head 50412ae differs from pull request most recent head 68d808f. Consider uploading reports for the commit 68d808f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   73.75%   73.48%   -0.28%     
==========================================
  Files         110      107       -3     
  Lines        7332     7049     -283     
==========================================
- Hits         5408     5180     -228     
+ Misses       1924     1869      -55     
Impacted Files Coverage Δ
src/haddock/__init__.py 96.15% <0.00%> (-0.15%) ⬇️
src/haddock/modules/analysis/caprieval/capri.py 82.31% <0.00%> (-0.09%) ⬇️
src/haddock/clis/cli_analyse.py
tests/test_cli_analyse.py
src/haddock/libs/libplots.py
src/haddock/libs/libworkflow.py 30.13% <0.00%> (+0.13%) ⬆️
src/haddock/clis/cli.py 34.32% <0.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgiulini mgiulini self-assigned this Feb 20, 2023
@mgiulini mgiulini merged commit 02ed904 into main Mar 6, 2023
@mgiulini mgiulini deleted the update_paths_analyse branch March 6, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

correct pdb relative paths analysis subfolders
3 participants