Removing stage key as a requirement for the configuration file
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomcteixeira
added
the
enhancement
* `stage` is now not necessary for `prepare_run` step * params returns from `prepare_run` do not contain the general config params
missing `begin_dir` and `remove dict keys` function.
Parameter `stream` was not used and was still received. Modified workflow.py to receive a config dict and not a stream Not fully functional code (yet)
Also: * opens space of `other parameters` TODO: * Adjust the `.run()` interface in `HaddockModules`.
|
Done, ready to review. The |
rvhonorato
requested changes
Aug 10, 2021
rvhonorato
approved these changes
Aug 10, 2021
joaomcteixeira
added a commit
to joaomcteixeira/haddock3
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue implementations discussed in #53.
Here's the draft PR while I work on it. Comments and suggestions are very welcomed.
Cheers,