-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep CNS scripts checking and example cleaning #763
Conversation
…sages Removing parameter duplications Fixing some issues with variables Cleaning/harmonizing examples config files
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=======================================
Coverage 72.54% 72.55%
=======================================
Files 80 80
Lines 7566 7571 +5
=======================================
+ Hits 5489 5493 +4
- Misses 2077 2078 +1 ☔ View full report in Codecov by Sentry. |
@rvhonorato - tests are failing on my mac because of a difference in the 15th digit in the contacts module test...
As for the alascan integration test, if might need to be revisited... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this pull request might appear rather large, the changes are somewhat limited:
-
54 of 98 files are cleaned config file examples (harmonisation and cleaning unneeded paramters/steps)
-
26 files are topo/param files, mainly with harmonised CNS verbosity settings.
-
A few files from the toppar directory have large differences because their line endings were corrected from Windows to Linux. Their content is further the same.
-
Most of the remaining files are CNS scripts with rather minor corrections to remove error messages (e.g. correcting a variable name). Some missing in a module were added.
It's impossible for me to review 1.000+ lines, if you think its ok just go ahead and merge it! |
It is possible :-)
A lot of those 1000 lines are simply files in which I corrected Windows style line ending into Linux.
All others have very similar changes.
|
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
A careful check of all output files of the various examples revealed several small issues like duplication of some parameters, missing variables in some CNS scripts, inconsistencies between files (format mainly) and example config files.
This pull request resolves all those issues.