-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contact map analysis module #731
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 70.25% 72.45% +2.19%
==========================================
Files 78 80 +2
Lines 6967 7547 +580
==========================================
+ Hits 4895 5468 +573
- Misses 2072 2079 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition, just some small comments to be addressed and please add an integration test.
Cool, the contacts can also be rendered in a mol viewer like
Nevermind its already an issue at #733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plot looks nice, but I wonder if this is what we want to show to the users. The majority of the contact map is dominated by intra-chain contacts, and that's what draws the attention...isn't it better to focus between inter-chain contacts so as to visualize contacts at the interface?
also, I am bit concerned about the size of the output, every contact map tsv file is 6 MB and the html is almost 5 MB..reducing the number of digits for a field (see comment) can improve things..but maybe this another argument in favour of showing only inter-chain contacts
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
It as a good solution too.
Indeed, big issue... Maybe a simple |
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
let's go for it then!
nah, being able to visualize the contacts interactively is super cool! |
What about generating instead those circular plots (the circle being the sequence) with the contacts (intermolecular) being shown between chains. Like is being done to display crosslinks for example
Joao Rodrigues wrote a library for this kind of analysis if I am correct
Check https://github.com/JoaoRodrigues/interfacea <https://github.com/JoaoRodrigues/interfacea>
|
…into contact-maps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added just a few comments here and there, the coordinate chart is truly beautiful!
feel free to merge as is
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
Co-authored-by: Marco Giulini <54807167+mgiulini@users.noreply.github.com>
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
tox
tests pass. Runtox
command inside the repository folder-test.cfg
examples execute without errors. Insideexamples/
runpython run_tests.py -b
This closes #733 .
As a response to users request, a new analysis module is now available for user to generate contact maps of the generated structures.
The module will mainly focus on generating contact map on a per-cluster basis.
It is also possible to generate map for single structures.
Two type of graphs can be generated: heatmaps and chordcharts.