Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for testing #108

Merged
merged 44 commits into from
Jun 18, 2022

Conversation

joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Jul 5, 2021

Closes #100

  • Tests Ubuntu, MacOS, Windows
  • Tests python 2.7, 3.6 to 3.9
  • Runs UnitTests on all platforms/versions (sends report to CodeCov)
  • tests package build and bump2version on all platforms/versions
  • Updates README.rst badges

@joaomcteixeira joaomcteixeira requested a review from a team July 5, 2021 18:55
@joaomcteixeira joaomcteixeira self-assigned this Jul 5, 2021
@joaomcteixeira joaomcteixeira marked this pull request as draft July 5, 2021 18:58
@joaomcteixeira
Copy link
Member Author

Build is passing well, but tests are failing while passing locally. Git actions is closing I/O before time

ValueError: I/O operation on closed file

needs research...

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #108 (2b3f199) into master (4cbefcc) will increase coverage by 0.83%.
The diff coverage is 97.42%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   82.34%   83.18%   +0.83%     
==========================================
  Files          47       48       +1     
  Lines        3711     3878     +167     
  Branches      767      798      +31     
==========================================
+ Hits         3056     3226     +170     
+ Misses        465      463       -2     
+ Partials      190      189       -1     
Impacted Files Coverage Δ
pdbtools/pdb_fetch.py 0.00% <0.00%> (ø)
pdbtools/pdb_tidy.py 82.01% <91.30%> (+7.21%) ⬆️
pdbtools/pdb_selaltloc.py 92.05% <96.71%> (+1.90%) ⬆️
pdbtools/__init__.py 100.00% <100.00%> (ø)
pdbtools/pdb_b.py 85.18% <100.00%> (+0.18%) ⬆️
pdbtools/pdb_chain.py 84.61% <100.00%> (+0.19%) ⬆️
pdbtools/pdb_chainbows.py 87.50% <100.00%> (+0.19%) ⬆️
pdbtools/pdb_chainxseg.py 94.54% <100.00%> (+0.10%) ⬆️
pdbtools/pdb_chkensemble.py 87.64% <100.00%> (+0.14%) ⬆️
pdbtools/pdb_delchain.py 84.81% <100.00%> (+0.19%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0312bc4...2b3f199. Read the comment docs.

@JoaoRodrigues
Copy link
Member

OK, summary after a ton of tinkering:

  1. Github Actions are utterly broken when it comes to handling TTYs. See Not a tty actions/runner#241
  2. Because of the above, I had to disable Win testing.
  3. Separated coverage/linting/building/testing to avoid redundancy and help manage different OSes.
  4. Some tests are failing on Python 2.7, @joaomcteixeira: they are about pdb_selaltloc!
  5. Added flake8 linting to CI.

JoaoRodrigues and others added 5 commits June 18, 2022 19:16
* Add new tests

* add tests for the new scenario
* add vu7.pdb for tests that went missing on previous version

* correct implementation and add tests
@JoaoRodrigues JoaoRodrigues marked this pull request as ready for review June 18, 2022 23:23
@JoaoRodrigues JoaoRodrigues merged commit a781b46 into haddocking:master Jun 18, 2022
@joaomcteixeira joaomcteixeira deleted the githubactions branch April 5, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub Actions
3 participants