Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use "remotes" package #1310

Closed
wants to merge 3 commits into from
Closed

WIP: Use "remotes" package #1310

wants to merge 3 commits into from

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Aug 26, 2016

Had to remove/disable a few tests. A first test of devtools::install_github("hadley/tibble@r-1.2") went well, but it'll need to sit for a while until it's good. Also, need to migrate the missing remote types to "remotes".

CC @gaborcsardi.

@gaborcsardi
Copy link
Member

Note that remotes does have some important open bugs, e.g. compiling on windows.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 26, 2016

It's really not much more than a proof of concept now. I'll use this on my machine and update the branch as necessary. Feel free to beta-test, too.

@hadley
Copy link
Member

hadley commented Nov 3, 2016

I'd like to have a plan to get this merged into the next release of devtools. Is there a good list of missing functionality?

@gaborcsardi
Copy link
Member

Here is a list:

Various fixes. These might or migth not be relevant:

Plus a bunch of stuff potentially in install.r, I didn't go over all of these:
https://github.com/hadley/devtools/commits/master/R/install.r

So, yeah, a lot of stuff....

@hadley
Copy link
Member

hadley commented Nov 4, 2016

Yeah, that's a lot of stuff.

I think we also need to do quite a bit of refactoring with an eye to making it all easier to test (i.e. separating out a data structure that describes a set of need actions and performing those actions). I'm not sure how much of that you did in remotes?

@gaborcsardi
Copy link
Member

gaborcsardi commented Nov 4, 2016

I'm not sure how much of that you did in remotes?

Not much. It is basically the code from (old) devtools, fixed up a bit, and some extra to get rid of dependencies or make dependencies optional.

I would not mind refactoring it.

@hadley
Copy link
Member

hadley commented Aug 1, 2017

Let's close this for now. I think we'll aim for a release of devtools that incorporates the existing diaspora about from remotes. And then we'll aim for another release fairly soon after that aims to switch over to remotes.

@hadley hadley closed this Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants