-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Use "remotes" package #1310
Conversation
Note that |
It's really not much more than a proof of concept now. I'll use this on my machine and update the branch as necessary. Feel free to beta-test, too. |
I'd like to have a plan to get this merged into the next release of devtools. Is there a good list of missing functionality? |
Here is a list:
Various fixes. These might or migth not be relevant: Plus a bunch of stuff potentially in So, yeah, a lot of stuff.... |
Yeah, that's a lot of stuff. I think we also need to do quite a bit of refactoring with an eye to making it all easier to test (i.e. separating out a data structure that describes a set of need actions and performing those actions). I'm not sure how much of that you did in remotes? |
Not much. It is basically the code from (old) devtools, fixed up a bit, and some extra to get rid of dependencies or make dependencies optional. I would not mind refactoring it. |
Let's close this for now. I think we'll aim for a release of devtools that incorporates the existing diaspora about from remotes. And then we'll aim for another release fairly soon after that aims to switch over to remotes. |
Had to remove/disable a few tests. A first test of
devtools::install_github("hadley/tibble@r-1.2")
went well, but it'll need to sit for a while until it's good. Also, need to migrate the missing remote types to "remotes".CC @gaborcsardi.