Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package installation for revdep_check is not parallelized #1331

Closed
wch opened this issue Sep 7, 2016 · 3 comments
Closed

Package installation for revdep_check is not parallelized #1331

wch opened this issue Sep 7, 2016 · 3 comments
Labels
feature a feature request or enhancement install

Comments

@wch
Copy link
Member

wch commented Sep 7, 2016

I think it used to be the case that when revdep_check() was called with a value for Ncpus, it would install packages in parallel because it passed Ncpus to install.packages(). Now the packages seem to be installed one at a time, which is much slower -- I'm installing over 600 packages for a revdep check, so the cost is not trivial. I believe this happens because it ends up calling install_remotes, which looks like it installs packages one at a time.

@krlmlr
Copy link
Member

krlmlr commented Sep 7, 2016

I've been through this with RSQLite. It's a one-time cost, which you can alleviate by setting MAKEFLAGS=-j $(nproc) .

See r-lib/remotes#34 for a related discussion; looks like devtools might eventually forward to the "remotes" package (#1310).

@hadley hadley added feature a feature request or enhancement install labels Nov 3, 2016
@hadley
Copy link
Member

hadley commented Aug 2, 2017

This will be/is resolved in the new revdepcheck package

@hadley hadley closed this as completed Aug 2, 2017
@lock
Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement install
Projects
None yet
Development

No branches or pull requests

3 participants