Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 926 (problems with escaping table names for SQLite databases) #1218

Closed
wants to merge 2 commits into from

Conversation

NikNakk
Copy link

@NikNakk NikNakk commented Jun 14, 2015

Fixed issues described with SQLite at https://github.com/hadley/dply/issues/926 by creating new function for db_insert_into that supports escaping (unlike the current DBI::dbWriteTable that was used) and using build_sql rather than paste0 within db_query_fields.

This was also raised at http://stackoverflow.com/questions/28132697/bracket-escaped-table-names-with-dplyr

Nick Kennedy added 2 commits June 14, 2015 23:57
…unction for db_insert_into that supports escaping (unlike the current DBI::dbWriteTable that was used) and using build_sql rather than paste0 within db_query_fields.
@NikNakk
Copy link
Author

NikNakk commented Jun 15, 2015

Realised I'd not included the code to clear up resources (dbClearResult) from DBI::dbWriteTable; included now. It should be noted also that the db_insert_into.SQLiteConnection differs from the previous version in that it will never create a new table. At present, it's only called from copy_to which creates the table first anyway, and to my mind a function called db_insert_to generally should be appending into an existing table, with a separate call to create the table. If the previous behaviour is preferred, then additional code to call db_create_table as needed could be added.

@NikNakk NikNakk closed this Jul 10, 2015
@NikNakk
Copy link
Author

NikNakk commented Jul 10, 2015

Closed because was based on my master branch which made making any other changes problematic until this PR was successful

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant