Approach facet_grid(scale="free") + coord_flip issue

[vlsi]

I've run into "well known" facet_grid(scale="free") + coord_flip() issue, and it took me a several hours to find a workaround, thus I decided to implement a proper fix.

The idea is to swap panel$layout$SCALE_X and panel$layout$SCALE_Y right after train_layout

The thing is facet_grid tries to keep the same ranges for all columns and rows,
however it does not know if the axes will be flipped, so when flip occurs
the previously chosen set of facets no longer applies.

The fix is to flip SCALE_X and SCALE_Y set of facets, so the ranges are properly computed

Fixes #1492, #1470, #1393, #95

[hadley]

I have to say I thought I was going to hate this, but it seems so simple that it's worth doing. It doesn't solve the general problem but it's a pragmatic solution to the case that most people encounter. Could you have a look at doing it for facet_grid() too?

And all the facetting code has been rewritten in #1633 but I think the basic idea will still work.

cc @thomasp85

[vlsi]

Here's sample from #1470:

Test_df <- data.frame(Policy = rep(c("A", "B", "C", "D"), 4),
                      Measure = rep(c("Mixed Use", "Walking"), each = 8),
                      PctChg = c(10 * runif(8, 0, 1), 50 * runif(8, 0, 1)),
                      Model = rep(rep(c("RPAT", "RSPM"), each = 4), 2)
)

ggplot(data = Test_df, aes(x=Policy, y = PctChg, fill = Model)) + 
  geom_bar(stat = "identity", position=position_dodge()) +
  facet_grid(. ~ Measure, scales = "free") +
  coord_flip() +
  theme_bw() + 
  labs(y = "% Change from Reference") +
  labs(x = "") +
  theme(axis.title = element_text(size = 10))

Before:

After:

[vlsi]

Could you have a look at doing it for facet_grid() too?

It works for both facet_grid and facet_wrap

[vlsi]

I have to say I thought I was going to hate this, but it seems so simple that it's worth doing. It doesn't solve the general problem but it's a pragmatic solution to the case that most people encounter

Exactly. I feel what you mean by "facets and coordinate systems are not well designed to play together", however I think the fix is rather trivial, so it might have its purpose

[thomasp85]

Thanks for this @vlsi - I'll add it to #1633 though in a slightly different way that doesn't modify the build code itself.

[thomasp85]

This was fixed in #1633

[lock]

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/