colwise messes replicated names #106

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@vspinu
vspinu commented Oct 18, 2012

Setdiff in strip_splits makes names unique. This leads to an obscure bug which is very difficult to spot if you deal with large number of columns.

Example:

   > df <- data.frame(a = 23, a = 56, check.names = F)
   > colwise(mean)(df)
      a
   1 23
   > 
@hadley
Owner
hadley commented Oct 18, 2012

Would you mind also contributing a test case? Thanks!

@vspinu
vspinu commented Oct 18, 2012

Sure. Done.

hadley wickham notifications@github.com
on Thu, 18 Oct 2012 15:33:10 -0700 wrote:

hw> Would you mind also contributing a test case? Thanks!
hw> ---
hw> Reply to this email directly or view it on GitHub:
hw> #106 (comment)

@hadley
Owner
hadley commented Jan 2, 2014

Could you please rebase/merge?

@hadley
Owner
hadley commented Jan 2, 2014

And resubmit. Thanks!

@hadley hadley closed this Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment