Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colwise messes replicated names #106

Closed
wants to merge 2 commits into from
Closed

colwise messes replicated names #106

wants to merge 2 commits into from

Conversation

vspinu
Copy link

@vspinu vspinu commented Oct 18, 2012

Setdiff in strip_splits makes names unique. This leads to an obscure bug which is very difficult to spot if you deal with large number of columns.

Example:

   > df <- data.frame(a = 23, a = 56, check.names = F)
   > colwise(mean)(df)
      a
   1 23
   >

@hadley
Copy link
Owner

hadley commented Oct 18, 2012

Would you mind also contributing a test case? Thanks!

@vspinu
Copy link
Author

vspinu commented Oct 18, 2012

Sure. Done.

hadley wickham notifications@github.com
on Thu, 18 Oct 2012 15:33:10 -0700 wrote:

hw> Would you mind also contributing a test case? Thanks!
hw> ---
hw> Reply to this email directly or view it on GitHub:
hw> #106 (comment)

@hadley
Copy link
Owner

hadley commented Jan 2, 2014

Could you please rebase/merge?

@hadley
Copy link
Owner

hadley commented Jan 2, 2014

And resubmit. Thanks!

@hadley hadley closed this Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vspinu @hadley