Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #1007

Closed
wants to merge 1 commit into from
Closed

fix typos #1007

wants to merge 1 commit into from

Conversation

spaette
Copy link

@spaette spaette commented Jul 7, 2023

Closes #997

code.Rmd
dependencies-in-practice.Rmd
description.Rmd
lifecycle.Rmd
package-within.Rmd
whole-game.Rmd

@spaette spaette mentioned this pull request Jul 7, 2023
@spaette
Copy link
Author

spaette commented Sep 8, 2023

@jennybc

Would you be OK with going ahead and merging this.

@jennybc
Copy link
Collaborator

jennybc commented Sep 15, 2023

No I can't/won't. In many cases you are making changes in, e.g. code comments that are copied verbatim from an actual package or just comments that are a note-to-self for the book authors. So this PR is a mix of a very few things that are only marginally helpful, from the perspective of this book, and other changes that are not.

I know this is well-intentioned but these PRs that seem to consist of just running a spell checker over the book files, without actually engaging with what the material is for, really aren't helpful.

@jennybc jennybc closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typos
2 participants