Allow Perl-style regex filters for tests #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be tempted to use |
|
I'd be fine with that, but didn't want to steal |
|
I've updated to use |
|
Can you please rebase? |
|
Done. |
|
The diff doesn't look right to me - can you please double check? |
|
Oh, yea, that was weird. How does this look? |
| @@ -1,5 +1,9 @@ | |||
| # testthat 0.9.1.9000 | |||
|
|
|||
| * `test_dir`, `test_package`, and `test_check` have an added `...` argument | |||
There was a problem hiding this comment.
Doesn't look like you actually modified test_check() (which is right) but can you remove from here?
Also house style is to follow function names with (), e.g.test_dir().
|
Meant to modify Added parentheses to function names in NEWS. |
hadley
added a commit
that referenced
this pull request
Jan 7, 2015
Allow Perl-style regex filters for tests
jimhester
added a commit
to jimhester/devtools
that referenced
this pull request
Mar 24, 2015
Merged
jimhester
added a commit
to jimhester/devtools
that referenced
this pull request
Apr 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perl-style regular expressions are currently not allowed in the
filterargument totest_dir,test_package, andtest_check. This pull request adds aperlargument (logical, defaultFALSE) that enables Perl-style regular expressions, which is passed down togrepl.