--failure-threshold does not work as expected (exits 0) if set to level: 'error'

[Dentrax]

• This is a bug report
• This is a feature request
• I searched existing issues before opening this one

Expected behavior

It should exit with 1.

Actual behavior

It exits with 0.

Steps to reproduce the behavior

1. $ hadolint --failure-threshold error --verbose ./Dockerfile
2. echo $? # prints 0

No configuration was specified. Using default configuration
./Dockerfile:8 DL3020 error: Use COPY instead of ADD for files and folders
./Dockerfile:10 DL3000 error: Use absolute WORKDIR
./Dockerfile:19 DL3008 warning: Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
...

Output of hadolint --version:

Haskell Dockerfile Linter 2.4.1-no-git

[druwadi]

I'm having the same issue with this, I changed the trusted registry to create an error, and the error still passed the threshold.

[m-ildefons]

Sorry for the confusion on this. There was a lengthy discussion on whether or not the behavior should be inclusive or exclusive of the threshold itself here and the docs were updated here, but the behavior itself never changed.