threshold: tune behaviour to match help message #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help message suggests that the failure threshold makes Hadolint exit with failure when a rule above **or equal to** the threshold is violated. This was introduced to the help message with hadolint@3121fe9 But never updated the behaviour to match the help message. fixes: hadolint#651
|
Thanks for fixing it! |
m-ildefons
added a commit
to m-ildefons/hadolint
that referenced
this pull request
Mar 13, 2022
- Fix wrong information about the behavior of the `--failure-threshold` option. - Add instructions on how to build Hadolint against modified libraries to the development section. Since hadolint#653 , Hadolint has treated the failure threshold set by the `--failure-threshold` option as inclusive and this has been reflected in the `--help` message text. But the readme has never been updated. fixes: hadolint#788
lorenzo
pushed a commit
that referenced
this pull request
Mar 14, 2022
- Fix wrong information about the behavior of the `--failure-threshold` option. - Add instructions on how to build Hadolint against modified libraries to the development section. Since #653 , Hadolint has treated the failure threshold set by the `--failure-threshold` option as inclusive and this has been reflected in the `--help` message text. But the readme has never been updated. fixes: #788
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The help message suggests that the failure threshold makes Hadolint exit
with failure when a rule above or equal to the threshold is
violated. This was introduced to the help message with
3121fe9
But never updated the behaviour to match the help message.
fixes: #651