-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The --failure-threshold setting is treated as inclusive instead of exclusive #788
Comments
- Fix wrong information about the behavior of the `--failure-threshold` option. - Add instructions on how to build Hadolint against modified libraries to the development section. Since hadolint#653 , Hadolint has treated the failure threshold set by the `--failure-threshold` option as inclusive and this has been reflected in the `--help` message text. But the readme has never been updated. fixes: hadolint#788
Hi @kingrichard2005 , |
- Fix wrong information about the behavior of the `--failure-threshold` option. - Add instructions on how to build Hadolint against modified libraries to the development section. Since #653 , Hadolint has treated the failure threshold set by the `--failure-threshold` option as inclusive and this has been reflected in the `--help` message text. But the readme has never been updated. fixes: #788
Hi @m-ildefons , thanks for the quick follow-up and resolution. Glad to hear it was just a README update that was needed, that'll definitely help avoid confusion moving forward. |
Expected behavior
hadolint should treat the
--failure-threshold
setting as exclusive per documentation which indicatesExit with failure code only when rules with a severity above THRESHOLD are violated.
Actual behavior
hadolint treats the
--failure-threshold
setting as inclusive i.e. if the number of validation errors is equal to or greater than the threshold, the lint validation fails.Steps to reproduce the behavior
Output of
hadolint --version
ordocker run --rm hadolint/hadolint hadolint --version
ordocker run --rm ghcr.io/hadolint/hadolint hadolint --version
:Dockerfile (if relevant)
Additional environment details (OS, stack version, etc.)
The text was updated successfully, but these errors were encountered: