-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.hadolint.yaml config is ignored #775
Comments
Seems like this broke in 2.8.0. Using version 2.7.0 seems to read the config properly. When I used the ---
failure-threshold: error # name of threshold level (error | warning | info | style | ignore | none)
trustedRegistries:
- fail.docker.com $ hadolint -V -c $(pwd)/.hadolint.yaml Dockerfile
"Configuration file used: /Users/username/Repos/Test/.hadolint.yaml"
Configuration:
no fail: False
no color: False
output format: tty
failure threshold: error
override error:
none
override warning:
none
override info:
none
override style:
none
override ignore:
none
strict labels: False
label schema:
none
allowed registries:
none |
It is not only trustedregistries - it seems everything in the config is ignored |
@jornfranke it's actually only a few things from what I can tell. |
Also reporting failure-threshold not working correctly. The following within .hadolint.yaml...
yields...
Other values in the hadolint.yaml file work fine. |
Make Hadolint read the desired output format from the key `format` in the config file, instead of `output-format`. This is more convenient, consistent with the command line options and consistent with the documentation. fixes: hadolint#775
Make Hadolint read the desired output format from the key `format` in the config file, instead of `output-format`. This is more convenient, consistent with the command line options and consistent with the documentation. fixes: hadolint#775
Make Hadolint read the desired output format from the key `format` in the config file, instead of `output-format`. This is more convenient, consistent with the command line options and consistent with the documentation. fixes: #775
Expected behavior
hadolint reads the file .hadoolint.yaml and applies the options. E.g. in this case it should especially consider output format "format" in it.
Actual behavior
hadolint ignores at least the option "format" in the yaml, but most likely all options. If I provide a non-existing file then it complains that it cannot read the file, so I assume it finds the file and content.
If I provide the format via the -f flag then it is correctly produced.
Steps to reproduce the behavior
Use the following file ./hadolint.yaml
It will not output the issues in "gitlab_codeclimate" format, but the default tty.
hadolint version: 2.8.0
OS: Linux
Gitlab Runner: 14.7.0
The text was updated successfully, but these errors were encountered: