Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi input tools #8

Merged
merged 10 commits into from
Aug 10, 2023
Merged

Multi input tools #8

merged 10 commits into from
Aug 10, 2023

Conversation

haesleinhuepf
Copy link
Owner

@haesleinhuepf haesleinhuepf commented Aug 9, 2023

Hey @kevinyamauchi ,

thanks again for working on this ! This PR closes #7 and closes #1

To prevent markdown-images (![]()), I'm using a regexp now. It was hard to prevent this output otherwise.

I reran all notebooks and modified tiny bits. I have the impression that the new agent is smarter than the old. Two examples:

  • I've seen multiple cases where I asked "segment the image" and it also showed the image.
  • In the segmentation_algorithms notebook, it was hard to fool Bob. It always used the right algorithm for the membranes.tif image, presumably because the name of the file (membranes) appears in the description of an algorithm. I had to rename the image to demonstrate how to make it choose the right algorithm.

Fantastic work! Do you see any other reason for not merging this?

Thanks again!

Best,
Robert

@haesleinhuepf
Copy link
Owner Author

haesleinhuepf commented Aug 9, 2023

I'm playing mroe with it and see that the agent tends to execute tasks multiple times (such as showing images) and sometimes even runs in [endless] loops.

Edit: I think this is fixed in #9

@haesleinhuepf
Copy link
Owner Author

I love this

image

@kevinyamauchi
Copy link
Collaborator

Edit: I think this is fixed in #9

Nice! I'll have a look tomorrow. In case it's not, I found this comment that might be useful:

langchain-ai/langchainjs#1290 (comment)

@kevinyamauchi
Copy link
Collaborator

I love this

Dude, yeah, this is super exciting!

@haesleinhuepf haesleinhuepf merged commit 908c9b5 into main Aug 10, 2023
1 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine operands
2 participants