-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Prism plugin #67
Conversation
Update: I found a better way and opened PR #69. @benevbright @tobmaster: do you have any idea how to improve/configure this? You can see the error here: https://travis-ci.org/hagenburger/pimd/jobs/433770967 |
8a7cdde
to
5672b68
Compare
@hagenburger hmmm do you really want to test all plugins with the main project? IMHO those should just have their own test suite and been tested individually? |
@tobmaster how would you set this up? |
5672b68
to
8bd38ef
Compare
@benevbright I just rebased and included #70. |
@benevbright it seems not to work with the |
Hm... can you exclude package-lock.json? |
How and for which result?
|
I mean, can you remove package-lock.json in prism plugin and push again? |
@benevbright OK … seems to fix it. |
@benevbright is it approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm!
No description provided.