Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Prism plugin #67

Merged
merged 2 commits into from
Sep 29, 2018
Merged

Implement Prism plugin #67

merged 2 commits into from
Sep 29, 2018

Conversation

hagenburger
Copy link
Owner

No description provided.

@hagenburger hagenburger added enhancement New feature or request plugin labels Sep 26, 2018
@hagenburger hagenburger added this to the v1.0.0 milestone Sep 26, 2018
@hagenburger
Copy link
Owner Author

hagenburger commented Sep 26, 2018 •
edited
Loading

I’m pretty unhappy with the fix needed for Travis CI.

Update: I found a better way and opened PR #69.

@benevbright @tobmaster: do you have any idea how to improve/configure this? You can see the error here: https://travis-ci.org/hagenburger/pimd/jobs/433770967

@tobmaster
Copy link

@hagenburger hmmm do you really want to test all plugins with the main project? IMHO those should just have their own test suite and been tested individually?

@hagenburger
Copy link
Owner Author

@tobmaster how would you set this up?

@hagenburger
Copy link
Owner Author

@benevbright I just rebased and included #70.

@hagenburger
Copy link
Owner Author

@benevbright it seems not to work with the npm install each install plugin folder :( Should we go back to lerna bootstrap or do you have any idea?

@benevbright
Copy link
Collaborator

Hm... can you exclude package-lock.json?

@hagenburger
Copy link
Owner Author

hagenburger commented Sep 29, 2018 via email

@benevbright
Copy link
Collaborator

I mean, can you remove package-lock.json in prism plugin and push again?

@hagenburger
Copy link
Owner Author

@benevbright OK … seems to fix it.

@hagenburger
Copy link
Owner Author

@benevbright is it approved?

benevbright
benevbright approved these changes Sep 29, 2018
View reviewed changes
Copy link
Collaborator

@benevbright benevbright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@hagenburger hagenburger merged commit 575191e into master Sep 29, 2018
@hagenburger hagenburger deleted the prismjs branch September 29, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benevbright benevbright benevbright approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request plugin
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hagenburger @tobmaster @benevbright