-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test ci for installing plugins' dependencies. #70
Conversation
Please note that I'm not good at naming. |
install_plugins_dependencies.sh
Outdated
if [[ -d $plugin ]]; then | ||
sh -c "cd $plugin && npm install" | ||
fi | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you indent with two spaces please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not exactly sure where to put this file.
https://gist.github.com/tracker1/59f2c13044315f88bee9#directories
./bin/
– this is usually for executables that will be bundled with the package./build/
– seems more accurate./scripts/
– that feels natural for Ruby projects. I’m not sure about the Node world.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I usually try to keep names with dash-case for consistency.
Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’ll squash and merge.
No description provided.