Test ci for installing plugins' dependencies. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benevbright
added
work in progress
|
Please note that I'm not good at naming. |
hagenburger
requested changes
Sep 28, 2018
install_plugins_dependencies.sh
Outdated
| if [[ -d $plugin ]]; then | ||
| sh -c "cd $plugin && npm install" | ||
| fi | ||
| done |
There was a problem hiding this comment.
Can you indent with two spaces please?
There was a problem hiding this comment.
I’m not exactly sure where to put this file.
https://gist.github.com/tracker1/59f2c13044315f88bee9#directories
./bin/– this is usually for executables that will be bundled with the package./build/– seems more accurate./scripts/– that feels natural for Ruby projects. I’m not sure about the Node world.
There was a problem hiding this comment.
I usually try to keep names with dash-case for consistency.
|
Thanks for the review. |
hagenburger
approved these changes
Sep 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.