github doesn't add itself to the package list

[bquistorff]

I did a fresh install of github and used it to install rcall. During the installation process its dependency.do queried for the github version, which isn't in the dataset, giving the following error:

. quietly github version github
github package was not found

I'm not sure if this is a rcall or github issue.

[randrescastaneda]

Did you use github to install github? Say, github install haghish/github. If you do, it works fine.

@bquistorff

[bquistorff]

No, I did a net install following the instructions).

[randrescastaneda]

Right. The problem is that github version reads from file g/github.dta , which is updated with the subcommand githubdb add. This subcommand is executed inside github install right after the Stata package is installed using net install. One solution is suggest the following in the instructions

net install github, from("https://haghish.github.io/github/")
github install haghish/github

or

net install github, from("https://haghish.github.io/github/")
githubdb add, address("haghish/github") username("haghish")  ///
		              reponame("github") name("github")

I know. It is overkill, but I don't see another way to solve it.

[bquistorff]

If they are feasible, a few other options that don't require user changes could be:

• github version has a special check for github.
• github version (or any other command that depends on the info), first checks if it's listed in g/github.dta and if not, does the githubdb add.

[mronkko]

This is clearly a bug. If a user does not have github installed, they must use the "net install" method. But if this method is used, installing rcall fails unless the user realizes that they must install github twice for it to actually work.