-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] Fix access methods for creating parts from external files #5501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
PR Summary: The pull request introduces updates to the access methods for creating parts from external files in the Abaqus scripting interface. It modifies the documentation notes within the PartBase.py file to reflect the correct access methods for various part creation functions, such as PartFromBooleanCut, PartFromBooleanMerge, PartFromExtrude2DMesh, and others. This change ensures that users are correctly guided on how to access these functions programmatically.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Consider adding examples of usage for the newly updated access methods in the documentation. This could further assist users in understanding how to utilize these functions effectively.
- Review the entire documentation for consistency in naming and access patterns to ensure that these changes align with the overall documentation style and guidelines.
- Since the PR mentions backporting to previous releases, ensure that the changes are compatible with the APIs of those versions to avoid introducing breaking changes.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
Description
Backporting
This change should be backported to the previous releases, please add the relevant labels.
Refer here to resolve backport conflicts if any.