Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix access methods for creating parts from external files #5501

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

haiiliin
Copy link
Owner

Description

Backporting

This change should be backported to the previous releases, please add the relevant labels.
Refer here to resolve backport conflicts if any.

  • 2016
  • 2017
  • 2018
  • 2019
  • 2020
  • 2021
  • 2022
  • 2023
  • 2024

@keywordlabeler keywordlabeler bot added backport-to-2016 Backport to 2016 branch backport-to-2017 Backport to 2017 branch backport-to-2018 Backport to 2018 branch backport-to-2019 Backport to 2019 branch backport-to-2020 Backport to 2020 branch backport-to-2021 Backport to 2021 branch backport-to-2022 Backport to 2022 branch backport-to-2023 Backport to 2023 branch bugfix labels Feb 25, 2024
@haiiliin haiiliin merged commit cb15509 into 2024 Feb 25, 2024
6 checks passed
@haiiliin haiiliin deleted the fix-part-access branch February 25, 2024 11:24
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5502)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5503)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5504)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5505)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5506)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5507)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot pushed a commit that referenced this pull request Feb 25, 2024
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5508)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
mergify bot added a commit that referenced this pull request Feb 25, 2024
…ackport #5501) (#5509)

[bugfix] Fix access methods for creating parts from external files (#5501)

(cherry picked from commit cb15509)

Co-authored-by: Hailin Wang <hailin.wang@connect.polyu.hk>
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces updates to the access methods for creating parts from external files in the Abaqus scripting interface. It modifies the documentation notes within the PartBase.py file to reflect the correct access methods for various part creation functions, such as PartFromBooleanCut, PartFromBooleanMerge, PartFromExtrude2DMesh, and others. This change ensures that users are correctly guided on how to access these functions programmatically.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Consider adding examples of usage for the newly updated access methods in the documentation. This could further assist users in understanding how to utilize these functions effectively.
  • Review the entire documentation for consistency in naming and access patterns to ensure that these changes align with the overall documentation style and guidelines.
  • Since the PR mentions backporting to previous releases, ensure that the changes are compatible with the APIs of those versions to avoid introducing breaking changes.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-2016 Backport to 2016 branch backport-to-2017 Backport to 2017 branch backport-to-2018 Backport to 2018 branch backport-to-2019 Backport to 2019 branch backport-to-2020 Backport to 2020 branch backport-to-2021 Backport to 2021 branch backport-to-2022 Backport to 2022 branch backport-to-2023 Backport to 2023 branch bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant