Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction #34

Merged
merged 1 commit into from
May 5, 2015
Merged

Small correction #34

merged 1 commit into from
May 5, 2015

Conversation

Akujiism
Copy link
Sponsor Contributor

@Akujiism Akujiism commented May 5, 2015

No description provided.

@stippi
Copy link
Sponsor Contributor

stippi commented May 5, 2015

Hi! It looks to me like the plural right below the corrected word should also be changed?

@Akujiism
Copy link
Sponsor Contributor Author

Akujiism commented May 5, 2015

In Russian we don’t write phrases from capital letters if there are symbols available before them. So in case of User reviews ‘Пользовательский отзыв’ without number (no reviews available) should be written from capital letter but without it - if a number is displayed before it. Since ‘Пользовательский отзыв’ is displayed in both cases I’ve decided to use the capital letter for 'viewPkg.userRating.title'. But ‘пользовательских отзывов’ for ‘viewPkg.userRating.title.plural’ is always displayed with a number that’s why it’s written without capital letter. The same issue is valid to ‘gen.pkg.title’ and ‘gen.pkg.title.plural’.

P.S. We also have different description of plurals depending on numbers ‘2-4’ and ‘5-etc.’ so that’s why I have to combine both strings into one i.e. ‘пакета(-ов)’, 'пользовательских рейтинга(-ов)’ (I'll update this one now BTW)

-- 
Regards,
Dmitriy Moroz
Sent with Airmail

On May 5, 2015 at 10:54:31 AM, stippi (notifications@github.com) wrote:

Hi! It looks to me like the plural right below the corrected word should also be changed?


Reply to this email directly or view it on GitHub.

stippi added a commit that referenced this pull request May 5, 2015
@stippi stippi merged commit abdac84 into haiku:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants