Cleanup for rebase #18

RAJAGOPALAN-GANGADHARAN · 2019-06-22T14:05:09Z

No description provided.

…string Note:destructors not handled yet

…ructure

"YOLO" isn't an helpful log message.

Initial implementation of IPC for haiku will add it to description each time i amend 1)added empty functions 2)fixed building issues and successfully created a connection between webprocess 3)Added a message handler to look out for incoming messages to runloop 4) Created new aux support so we can attach all handlers to the main apps looper

1)Added a message stashing feature so it stashes the messages and interprets them when the loop is ready to run 2)Now have to fix connection between network and webprocess

This time used maps to store loopers and BApplications to forward message to appropriate loopers

1) Created a message from ui process to network process that notifies the pid of webprocess 2) Successfully created networkconnectionToWebProcess 3) Replying back to webProcess is not working(to be fixed - i should probably take help from webkit people as im pretty lost)

…n loop for handshaking)

1) Added NetworkSession so it doesnt crash 2) Added missing run loop getter

1)This makes few important changes in adding the view 2)Partial mouse events which is kept aside now as main focus is put on webpage rendering

1) Few callbacks for finished loading and forward and backward stop etc is now fully functional 2) status text is partially done 3)shared memory done with mapping part pending(i need to understand a little bit more)

pulkomandy · 2019-06-22T14:16:34Z

Source/WebKit/NetworkProcess/NetworkProcess.cpp

@@ -32,19 +32,16 @@
 #include "AuthenticationManager.h"
 #include "AuxiliaryProcessMessages.h"
 #include "DataReference.h"
-#include "Download.h"


Why all the changes to this cross platform file? Did you accidentally use an older version?

pulkomandy · 2019-06-22T14:17:15Z

Source/WebKit/Platform/IPC/Connection.cpp

@@ -586,12 +586,29 @@ std::unique_ptr<Decoder> Connection::waitForSyncReply(uint64_t syncRequestID, Se
    WallTime absoluteTime = WallTime::now() + timeout;

    willSendSyncMessage(sendSyncOptions);
+<<<<<<< HEAD


You have committed this without fixing the conflicts

pulkomandy · 2019-06-22T14:18:23Z

Source/WebKit/Platform/IPC/HandleMessage.h

@@ -109,10 +110,10 @@ struct CodingType<std::tuple<Ts...>> {

 template<typename T, typename C, typename MF>
 void handleMessage(Decoder& decoder, C* object, MF function)
-{
+{notImplemented();


now you are using notImplemented in functions that are in fact implemented?
Wouldn't it make more sense to use BeDC at a lower level (in the logging framework of webkit) and use LogWithStream or whatever log support WebKit offers?

pulkomandy · 2019-06-22T14:19:13Z

Source/WebKit/Platform/haiku/SharedMemoryHaiku.cpp~HEAD

@@ -0,0 +1,116 @@
+/*


You have accidentally addded this file

pulkomandy · 2019-06-22T14:19:40Z

Source/WebKit/PlatformHaiku.cmake

    "${WEBKIT_DIR}/NetworkProcess/unix"
    "${WEBKIT_DIR}/Platform"
    "${WEBKIT_DIR}/Platform/IPC/unix"
    "${WEBKIT_DIR}/Shared/API/c/haiku"
    "${WEBKIT_DIR}/Shared/CoordinatedGraphics"
-    "${WEBKIT_DIR}/Shared/CoordinatedGraphics/threadedcompositor"
+	"${WEBKIT_DIR}/Shared/CoordinatedGraphics/threadedcompositor"


Here you removed an indentation cleanup that I did

pulkomandy · 2019-06-22T14:25:04Z

Source/WebKit/UIProcess/Launcher/haiku/ProcessLauncherHaiku.cpp

@@ -1,5 +1,5 @@
 /*
- *  Copyright (C) 2019 Haiku, Inc.
+ * Copyright (C) 2010, 2012 Apple Inc. All rights reserved.


pulkomandy · 2019-06-22T14:25:29Z

Source/WebKit/UIProcess/Launcher/haiku/ProcessLauncherHaiku.cpp

+
+    if (!m_client) {
+        // FIXME: Make Identifier a move-only object and release port rights/connections in the destructor.
+#if OS(DARWIN) && !PLATFORM(GTK)


This certainly has nothing to do in the Haiku version of this file

pulkomandy · 2019-06-22T14:26:30Z

Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -1073,6 +1073,8 @@ WebProcessProxy& WebPageProxy::ensureRunningProcess()

 RefPtr<API::Navigation> WebPageProxy::loadRequest(ResourceRequest&& request, ShouldOpenExternalURLsPolicy shouldOpenExternalURLsPolicy, API::Object* userData)
 {
+	fprintf(stderr,"Access:");
+	fprintf(stderr,"loadRequest: %d",m_isClosed);


Please stop using this type of logging in your commits. It's fine to have it temporarily when you debug something, but when you're done, remove it.

Also, use a \n in your logs...

pulkomandy · 2019-06-22T14:27:46Z

Tools/MiniBrowser/haiku/App.cpp

+
+
+	m_BackButton = new BButton("","Back",new BMessage(GO_BACK));
+    m_ForwardButton = new BButton("","Forward", new BMessage(GO_FORWARD));


what happened to the indentation here? We've been a bit inconsistent with it but at least try to use one type (either space or tabs) per function...

pulkomandy · 2019-06-22T14:29:04Z

Tools/MiniBrowser/haiku/CMakeLists.txt

@@ -1,3 +1,4 @@
+SET(CMAKE_BUILD_TYPE Debug)


I had removed this from the previous commits already. Setting the global variable here is a bad idea. You can set it on the target if you really need to debug MiniBrowser, but I suspect it will be of little help now that the UI is in place.

…wind and lldb. https://bugs.webkit.org/show_bug.cgi?id=205050 Reviewed by Michael Saboff. Before this patch, the stack trace from inside a probe function is cut off at ctiMasmProbeTrampoline: (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef) ... frame #4: 0x0000000100824607 JavaScriptCore`WTF::Function<void (JSC::Probe::Context&)>::operator(this=0x000000010b88bd00, in=0x00007ffeefbfd400)(JSC::Probe::Context&) const at Function.h:79:35 frame #5: 0x0000000100823996 JavaScriptCore`JSC::stdFunctionCallback(context=0x00007ffeefbfd400) at MacroAssembler.cpp:53:5 frame #6: 0x000000010082701e JavaScriptCore`JSC::Probe::executeProbe(state=0x00007ffeefbfd480) at ProbeContext.cpp:51:5 frame #7: 0x000000010082614b JavaScriptCore`ctiMasmProbeTrampoline + 299 (lldb) After this patch, we'll now get the full stack trace from inside the probe function: (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef) ... frame #4: 0x0000000100826d17 JavaScriptCore`WTF::Function<void (JSC::Probe::Context&)>::operator(this=0x0000000106b878f8, in=0x00007ffeefbfd400)(JSC::Probe::Context&) const at Function.h:79:35 frame #5: 0x0000000100826106 JavaScriptCore`JSC::stdFunctionCallback(context=0x00007ffeefbfd400) at MacroAssembler.cpp:53:5 frame #6: 0x000000010082986e JavaScriptCore`JSC::Probe::executeProbe(state=0x00007ffeefbfd480) at ProbeContext.cpp:51:5 frame #7: 0x00000001008289a2 JavaScriptCore`ctiMasmProbeTrampoline + 338 frame #8: 0x0000466db28025be frame #9: 0x0000000100754ffc JavaScriptCore`llint_entry at LowLevelInterpreter.asm:994 frame #10: 0x0000000100738173 JavaScriptCore`vmEntryToJavaScript at LowLevelInterpreter64.asm:307 frame #11: 0x0000000101489307 JavaScriptCore`JSC::JITCode::execute(this=0x0000000106ba1520, vm=0x0000000106d00000, protoCallFrame=0x00007ffeefbfd9b8) at JITCodeInlines.h:38:38 frame #12: 0x0000000101488982 JavaScriptCore`JSC::Interpreter::executeProgram(this=0x0000000106bfd1f8, source=0x00007ffeefbff090, (null)=0x000000010d0e0000, thisObj=0x000000010d0e8020) at Interpreter.cpp:847:51 frame #13: 0x00000001017d1f9c JavaScriptCore`JSC::evaluate(globalObject=0x000000010d0e0000, source=0x00007ffeefbff090, thisValue=JSValue @ 0x00007ffeefbfef60, returnedException=0x00007ffeefbff0b0) at Completion.cpp:146:38 frame #14: 0x000000010005838f jsc`runWithOptions(globalObject=0x000000010d0e0000, options=0x00007ffeefbff620, success=0x00007ffeefbff48b) at jsc.cpp:2670:35 frame #15: 0x000000010002a0da jsc`jscmain(this=0x00007ffeefbff5a0, vm=0x0000000106d00000, globalObject=0x000000010d0e0000, success=0x00007ffeefbff48b)::$_6::operator()(JSC::VM&, GlobalObject*, bool&) const at jsc.cpp:3157:13 frame #16: 0x0000000100006eff jsc`int runJSC<jscmain(int, char**)::$_6>(options=0x00007ffeefbff620, isWorker=false, func=0x00007ffeefbff5a0)::$_6 const&) at jsc.cpp:3003:9 frame #17: 0x0000000100005988 jsc`jscmain(argc=10, argv=0x00007ffeefbff6c8) at jsc.cpp:3150:18 frame #18: 0x000000010000575e jsc`main(argc=10, argv=0x00007ffeefbff6c8) at jsc.cpp:2498:15 frame #19: 0x00007fff6cfc4da9 libdyld.dylib`start + 1 frame #20: 0x00007fff6cfc4da9 libdyld.dylib`start + 1 (lldb) The difference is that the x86_64 ctiMasmProbeTrampoline now uses the standard function prologue, and keeps %rbp pointing to trampoline function's semblance of a frame that libunwind can understand while it calls the probe function. * assembler/MacroAssemblerX86Common.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

RAJAGOPALAN-GANGADHARAN and others added 16 commits June 22, 2019 18:06

Initial implementation to load blank url and now trying to load html …

693ced0

…string Note:destructors not handled yet

Added message handler to main run loop and made changes to webview st…

f8d83c5

…ructure

WebKit: missing include dirs, add coordinatedgraphics sourcefiles

e4dabbf

WebProcessPool: remove changes in cross platform code

e72221c

WebProcessPoolHaiku: fix tracing.

abbf0d9

"YOLO" isn't an helpful log message.

Message Listener attached to Workqueue thread first iteration

3710801

1)Added a message stashing feature so it stashes the messages and interprets them when the loop is ready to run 2)Now have to fix connection between network and webprocess

Fixed the worqueue ambiguity

451791e

This time used maps to store loopers and BApplications to forward message to appropriate loopers

Tried the new Adding messenger technique (relies only once on the mai…

04d5e10

…n loop for handshaking)

Finalizing IPC communication related things

3cd84c4

1) Added NetworkSession so it doesnt crash 2) Added missing run loop getter

Enable logging with BeDC

d73a91a

Adding the view to Minibrowser and adding few buttons

7847639

Partial implementation of mouse events

d6e2e61

1)This makes few important changes in adding the view 2)Partial mouse events which is kept aside now as main focus is put on webpage rendering

Widget and shared memory

fcbf9ea

1) Few callbacks for finished loading and forward and backward stop etc is now fully functional 2) status text is partially done 3)shared memory done with mapping part pending(i need to understand a little bit more)

Fixed Shared Memory and Started Network Process implementation

bd654c6

pulkomandy suggested changes Jun 22, 2019

View reviewed changes

RAJAGOPALAN-GANGADHARAN closed this Jun 29, 2019

RAJAGOPALAN-GANGADHARAN deleted the cleanup-for-rebase branch June 29, 2019 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup for rebase #18

Cleanup for rebase #18

RAJAGOPALAN-GANGADHARAN commented Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019

pulkomandy Jun 22, 2019



		m_BackButton = new BButton("","Back",new BMessage(GO_BACK));
		m_ForwardButton = new BButton("","Forward", new BMessage(GO_FORWARD));

Cleanup for rebase #18

Cleanup for rebase #18

Conversation

RAJAGOPALAN-GANGADHARAN commented Jun 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment