Use DrawTiledBitmap to draw patterns #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge, phaseOffset will be wrong. |
* Fixes #16202.
|
Ready to merge. Tested with https://paste.ubuntu.com/p/mf7sRysck9/, looks the same as in Firefox pixel for pixel, although app_server fix may be needed after all. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this does not require app_server fixes.
It turns out WebKit phase has different semantics than app_server phase.
In case of whatif.xkcd.com the calculation below results in phase of (0, 0).
I have confirmed that it renders as it did before, and corresponds to how Firefox renders the site on Linux.
I'm not sure if I got it completely correct though.