Jemalloc : new recipe #1965
Closed
Jemalloc : new recipe #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbrosson
reviewed
Dec 26, 2017
| # devel package | ||
| packageEntries devel \ | ||
| $developDir \ | ||
| $prefix/bin/jemalloc-config |
There was a problem hiding this comment.
I'd use
- $prefix/bin/jemalloc-config
+ $binDir/jemalloc-config|
|
||
| PROVIDES_devel=" | ||
| jemalloc${secondaryArchSuffix}_devel = $portVersion compat >= 5 | ||
| cmd:jemalloc_config |
There was a problem hiding this comment.
I'd write
- cmd:jemalloc_config
+ cmd:jemalloc_config$secondaryArchSuffix|
|
||
| PROVIDES=" | ||
| jemalloc$secondaryArchSuffix = $portVersion compat >= 5 | ||
| cmd:jemalloc.sh |
There was a problem hiding this comment.
I havent looked at anything other than your recipe, but I wonder if it would not be better to rename jemalloc.sh to jemalloc and write:
- cmd:jemalloc.sh
+ cmd:jemalloc$secondaryArchSuffix
- cmd:jeprof
+ cmd:jeprof$secondaryArchSuffixThere was a problem hiding this comment.
I just don't want the executables with _x86 postfix.
|
|
||
| TEST() | ||
| { | ||
| make check |
There was a problem hiding this comment.
I think you will need to pass a LIBRARY_PATH here, probably something like:
TEST()
{
+ LIBRARY_PATH="$sourceDir/lib${LIBRARY_PATH:+:$LIBRARY_PATH}" \
make check
}There was a problem hiding this comment.
It works already great, no need for more patching here.
|
Issue of interest: jemalloc/jemalloc#1040 (comment) |
|
Can you please retest this after the runtime_loader fixes? |
|
Will do! |
|
Still the same errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently untested on every platform as at least one test fails:
test_tsd_sub_thread:test/unit/tsd.c:83: Failed assertion: (data_cleanup_count) >= (3) --> 0x1 < 0x3: Cleanup function should have executed multiple times.test_tsd_sub_thread (non-reentrant): failtest_tsd_reincarnation (non-reentrant): pass--- pass: 2/3, skip: 0/3, fail: 1/3 ---<jemalloc>: test/unit/tsd.c:31: Unreachable code reachedAborttest/test.sh: line 34: 70246 Abort $JEMALLOC_TEST_PREFIX ${t} /sources/jemalloc-5.0.1/ /sources/jemalloc-5.0.1/Test harness error: test/unit/tsd w/ MALLOC_CONF=""Use prefix to debug, e.g. JEMALLOC_TEST_PREFIX="gdb --args" sh test/test.sh test/unit/tsd