go_md2man: new recipe #2079
go_md2man: new recipe #2079
Conversation
There was a problem hiding this comment.
As they vendored blackfriday, this port is subjected to said project licenses and copyright
| SUMMARY="Uses blackfriday to process markdown into man pages" | ||
| DESCRIPTION="go-md2man uses blackfriday to process markdown into man pages" | ||
| HOMEPAGE="https://github.com/cpuguy83/go-md2man" | ||
| COPYRIGHT="2017 Brian Goff" |
There was a problem hiding this comment.
-COPYRIGHT="2017 Brian Goff"
+COPYRIGHT="2017 Brian Goff
+ 2017 Russ Ross"| DESCRIPTION="go-md2man uses blackfriday to process markdown into man pages" | ||
| HOMEPAGE="https://github.com/cpuguy83/go-md2man" | ||
| COPYRIGHT="2017 Brian Goff" | ||
| LICENSE="MIT" |
There was a problem hiding this comment.
-LICENSE="MIT"
+LICENSE="MIT
+ BSD (2-clause)"| @@ -0,0 +1,60 @@ | |||
| SUMMARY="Uses blackfriday to process markdown into man pages" | |||
There was a problem hiding this comment.
Here's a better SUMMARY for you
-SUMMARY="Uses blackfriday to process markdown into man pages"
+SUMMARY="A utility to convert markdown to man pages"
| @@ -0,0 +1,60 @@ | |||
| SUMMARY="Uses blackfriday to process markdown into man pages" | |||
| DESCRIPTION="go-md2man uses blackfriday to process markdown into man pages" | |||
There was a problem hiding this comment.
And here's a better DESCRIPTION as well (from go-md2man.1)
go-md2man converts standard markdown formatted documents into manpages. It is written purely in Go so as to reduce dependencies on 3rd party libs.
Thanks. I didn't notice this, and this recipe needs to be updated. But I don't think putting two licenses there is a good idea, because people will think the project is dual-licensed, and that's probably not cpuguy83's intention. |
It's not the matter of good or bad, it's for legal purposes. The license explictly requires the copyright notice, and the license text (which we currently don't do but instead refer to them with |
|
@alaviss |
| BUILD_REQUIRES=" | ||
| haiku_devel | ||
| " | ||
|
|
There was a problem hiding this comment.
Please remove this blank line as required by our Guidelines
There was a problem hiding this comment.
I can't find where it says "no blank line in BUILD_REQUIRES". Could you point it out?
There was a problem hiding this comment.
From the Guidelines
The correct ordering and spacing of the variables inside the recipe is as follows:
BUILD_REQUIRES BUILD_PREREQUIRES
This recipe is a dependency of #2078.