Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Use binarySearch for larger and smaller in HistogramCombiner #5895

Merged
merged 1 commit into from
Apr 25, 2019
Merged

[bugfix] Use binarySearch for larger and smaller in HistogramCombiner #5895

merged 1 commit into from
Apr 25, 2019

Conversation

chrisvittal
Copy link
Collaborator

Fixes #5846

@chrisvittal
Copy link
Collaborator Author

I will add a test.

tpoterba
tpoterba previously requested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on test (req changes to appease scorecard)

tpoterba
tpoterba previously requested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@tpoterba tpoterba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the comments on #5846 -- I now think that -0.0 should go in the smaller category. We can do this by checking for nans first, then using java.lang.Double.compare in the rest of the comparisons.

@tpoterba
Copy link
Contributor

also d.isNan does an implicit conversion to java.lang.Double

🤦‍♂️

@chrisvittal chrisvittal force-pushed the issue-5846 branch 2 times, most recently from 58ebdc7 to 3c6d2d9 Compare April 25, 2019 17:51
@chrisvittal chrisvittal dismissed tpoterba’s stale review April 25, 2019 17:53

Okay this should be way better now.

@chrisvittal chrisvittal changed the title Coerce -0 to +0 in HistogramCombiner Use binarySearch for larger and smaller in HistogramCombiner Apr 25, 2019
@chrisvittal chrisvittal changed the title Use binarySearch for larger and smaller in HistogramCombiner [bugfix] Use binarySearch for larger and smaller in HistogramCombiner Apr 25, 2019
@danking danking merged commit 8d1f65e into hail-is:master Apr 25, 2019
@chrisvittal chrisvittal deleted the issue-5846 branch May 9, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpoterba tpoterba tpoterba approved these changes

Assignees

@tpoterba tpoterba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when running hl.agg.hist with value -0.0
3 participants
@chrisvittal @tpoterba @danking