[query] Fix simplify rule for nested TableFilterIntervals #9114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind explaining what was wrong / context? |
CHANGELOG: Fixed crash when using repeated calls to `hl.filter_intervals`.
tpoterba
commented
Jul 22, 2020
| @@ -769,7 +770,7 @@ object Simplify { | |||
| case TableFilterIntervals(TableAggregateByKey(child, expr), intervals, keep) => | |||
| TableAggregateByKey(TableFilterIntervals(child, intervals, keep), expr) | |||
| case TableFilterIntervals(TableFilterIntervals(child, i1, keep1), i2, keep2) if keep1 == keep2 => | |||
| val ord = child.typ.keyType.ordering.intervalEndpointOrdering | |||
| val ord = PartitionBoundOrdering(child.typ.keyType).intervalEndpointOrdering | |||
There was a problem hiding this comment.
Somewhat recently we refactored things so that the struct prefix ordering (where you can compare structs that may have different sizes) is separate from the IR struct ordering (assert same length). The former is now called PartitionBoundOrdering, and it's used with partition intervals (also filter_intervals). This is a bug because if you tried to filter a table with a length-2 key with length-1 intervals, you'd hit that assertion.
johnc1231
approved these changes
Jul 22, 2020
Dania-Abuhijleh
pushed a commit
to Dania-Abuhijleh/hail
that referenced
this pull request
Jul 23, 2020
CHANGELOG: Fixed crash when using repeated calls to `hl.filter_intervals`.
annamiraotoole
pushed a commit
to annamiraotoole/hail
that referenced
this pull request
Aug 3, 2020
CHANGELOG: Fixed crash when using repeated calls to `hl.filter_intervals`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.