Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Fix bug with constructing an array of empty structs #9751

Merged
merged 2 commits into from
Dec 3, 2020
Merged

[query] Fix bug with constructing an array of empty structs #9751

merged 2 commits into from
Dec 3, 2020

Conversation

johnc1231
Copy link
Contributor

@johnc1231 johnc1231 commented Nov 30, 2020 •
edited
Loading

Fixes #9750

The problem was that bool(hl.struct()) is False.

danking
danking previously requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add my example as a test!

@johnc1231 johnc1231 dismissed danking’s stale review December 1, 2020 17:57

Thanks for calling me out on not having a test.

@danking danking merged commit 025d4b2 into hail-is:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danking danking danking approved these changes

Assignees

@danking danking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hail cannot create an array of empty structs
2 participants
@johnc1231 @danking