Fix: no more flickering when switching visualization tabs.

hailocab · Mar 11, 2014 · f2ebfab · f2ebfab
1 parent 67f4c78
commit f2ebfab
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/rd_ui/app/scripts/directives.js b/rd_ui/app/scripts/directives.js
@@ -7,11 +7,11 @@
         return {
             restrict: 'E',
             scope: {
-                'id': '@',
+                'tabId': '@',
                 'name': '@'
             },
             transclude: true,
-            template: '<li class="rd-tab" ng-class="{active: id==selectedTab}"><a href="#{{id}}">{{name}}<span ng-transclude></span></a></li>',
+            template: '<li class="rd-tab" ng-class="{active: tabId==selectedTab}"><a href="#{{tabId}}">{{name}}<span ng-transclude></span></a></li>',
             replace: true,
             link: function(scope) {
                 scope.$watch(function(){return scope.$parent.selectedTab}, function(tab) {

diff --git a/rd_ui/app/views/queryfiddle.html b/rd_ui/app/views/queryfiddle.html
@@ -52,13 +52,13 @@ <h3 class="panel-title">
 
     <div class="row" ng-show="queryResult.getStatus() == 'done'">
         <ul class="nav nav-tabs">
-            <rd-tab id="table" name="Table"></rd-tab>
-            <rd-tab id="pivot" name="Pivot Table"></rd-tab>
+            <rd-tab tab-id="table" name="Table"></rd-tab>
+            <rd-tab tab-id="pivot" name="Pivot Table"></rd-tab>
             <!-- hide the table visualization -->
-            <rd-tab id="{{vis.id}}" name="{{vis.name}}" ng-hide="vis.type=='TABLE'" ng-repeat="vis in query.visualizations">
+            <rd-tab tab-id="{{vis.id}}" name="{{vis.name}}" ng-hide="vis.type=='TABLE'" ng-repeat="vis in query.visualizations">
                 <span class="remove" ng-click="deleteVisualization($event, vis)" ng-show="currentUser.canEdit(query)"> &times;</span>
             </rd-tab>
-            <rd-tab id="add" name="&plus; New" removeable="true" ng-show="currentUser.canEdit(query)"></rd-tab>
+            <rd-tab tab-id="add" name="&plus; New" removeable="true" ng-show="currentUser.canEdit(query)"></rd-tab>
         </ul>
 
         <div class="col-lg-12" ng-show="selectedTab == 'table'">

diff --git a/rd_ui/app/views/queryview.html b/rd_ui/app/views/queryview.html
@@ -88,12 +88,12 @@ <h1>
             <div class="row">
                 <div class="col-lg-12">
                     <ul class="nav nav-tabs">
-                        <rd-tab id="table" name="Table"></rd-tab>
-                        <rd-tab id="pivot" name="Pivot Table"></rd-tab>
-                        <rd-tab id="{{vis.id}}" name="{{vis.name}}" ng-hide="vis.type=='TABLE'" ng-repeat="vis in query.visualizations">
+                        <rd-tab tab-id="table" name="Table"></rd-tab>
+                        <rd-tab tab-id="pivot" name="Pivot Table"></rd-tab>
+                        <rd-tab tab-id="{{vis.id}}" name="{{vis.name}}" ng-hide="vis.type=='TABLE'" ng-repeat="vis in query.visualizations">
                             <span class="remove" ng-click="deleteVisualization($event, vis)" ng-show="canEdit"> &times;</span>
                         </rd-tab>
-                        <rd-tab id="add" name="&plus; New" removeable="true" ng-show="canEdit && isEditing"></rd-tab>
+                        <rd-tab tab-id="add" name="&plus; New" removeable="true" ng-show="canEdit && isEditing"></rd-tab>
                     </ul>
                 </div>
             </div>