Update binder

[malmans2]

No description provided.

[malmans2]

I've updated the binder repo. You can see a preview here: https://mybinder.org/v2/gh/hainegroup/oceanspy/binder?filepath=binder

[ThomasHaine]

Looks great! I ran the demo presentation and tutorial notebook with no issues (apart from a few warnings). I couldn't find the demo presentation in readthedocs after a brief exploration. It's worth putting it in (e.g.) Quick Start.

[malmans2]

Good idea! I've added the link in the home page and at the bottom of quick start. What do you think?

[ThomasHaine]

I don't see the presentation links.

[malmans2]

Are you looking at the readthedocs website?
If yes, it won't show the additions until we merge (you could compile locally following this).
If you look at the readme of this PR (https://github.com/hainegroup/oceanspy/tree/bind), there is this link: www.bndr.it/nakt7

The binder link it's not showing the Live_Demo.ipynb yet, it will once we merge. (Once we merge www.bndr.it/nakt7 will display this https://mybinder.org/v2/gh/hainegroup/oceanspy/binder?filepath=binder)

[malmans2]

Also, I'm fixing the tests in a separate PR!

[malmans2]

I pasted the wrong link before. Here is the correct link of this branch: https://github.com/hainegroup/oceanspy/tree/binder

[ThomasHaine]

OK, understood. I was looking at the readthedocs website. I'm happy to merge now and see the updated docs when they're live.

[ThomasHaine]

I pasted the wrong link before. Here is the correct link of this branch: https://github.com/hainegroup/oceanspy/tree/binder

Looks good!

[malmans2]

OK! If #163 passes all tests, I'll merge that one first, then this.

[malmans2]

All set!

[asiddi24]

Is it strange that when I run the binder it always runs on a jupyter notebook but not on jupyter lab ? Or is that just default in my system ?

[malmans2]

I don't remember if that was intentional, but I'm pretty sure there is a way to set it. (Maybe here https://github.com/hainegroup/oceanspy/blob/master/binder/postBuild or something similar?).

I'm thinking that classic jupyter might be easier for people that are not familiar with it, but feel free to explore the lab option if you think it's better!