-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pooch and update data #210
Conversation
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 10 10
Lines 3809 3809
Branches 849 849
=======================================
Hits 3630 3630
Misses 99 99
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Cool! So the test data will live in
Happy New year! How's the UK, or are you traveling anywhere fun? BTW I thought 'snow chains for your bike' was a joke, but it turns out its real! hahaha not yet (there is not enough snow) but will consider it in the future! |
Not sure if I can add contributors. We'll figure it out when we need it. But at least it's easier to find/more accessible, and we can also keep track of different versions.
Ahahaha, it was a joke! I'm in Italy right now, I should be back in the UK next week. It got pretty cold yesterday, but the weather has been amazing! |
* point to right directory where data is stored * [pre-commit.ci] pre-commit autoupdate (#207) updates: - [github.com/psf/black: 21.10b0 → 21.11b1](psf/black@21.10b0...21.11b1) - [github.com/nbQA-dev/nbQA: 1.1.1 → 1.2.1](nbQA-dev/nbQA@1.1.1...1.2.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit autoupdate (#208) updates: - [github.com/nbQA-dev/nbQA: 1.2.1 → 1.2.2](nbQA-dev/nbQA@1.2.1...1.2.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit autoupdate (#209) updates: - [github.com/psf/black: 21.11b1 → 21.12b0](psf/black@21.11b1...21.12b0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * update the location of zarr file * add name of catalog for test hycom file, and made some changes so that assertions are correct (dims and coords on HyCOM file are same) * reformatted using python black * Use pooch and update data (#210) * point to right directory where data is stored * update the location of zarr file * add name of catalog for test hycom file, and made some changes so that assertions are correct (dims and coords on HyCOM file are same) * reformatted using python black * replace `HyCOM` with `HYCOM` to read from intake catalog * minor fixes and corrections * Update oceanspy/tests/conftest.py * Delete Data Co-authored-by: Miguel Jimenez <mjimen17@jhu.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mattia Almansi <mattia.almansi@noc.ac.uk>
@Mikejmnez I've done a bunch of things:
hycom_test.{yaml,nc}
Please merge if it looks OK so you can make use of this changes in you PR.
BTW, Happy New Year!
Did you get snow chains for your bike?