update oceanspy_test environment #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikejmnez
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
MaceKuailv and
asiddi24
as code owners
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 10 10
Lines 3842 3842
Branches 811 811
=======================================
Hits 3664 3664
Misses 114 114
Partials 64 64
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
CI again builds the testing environment with an older version of matplotlib (version |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @MaceKuailv who figure out that there is an issue with matplotlib version > 3.5.2. See issue #269 for a description. Pinning down allows all tests to pass in my testing environment. It is also the reason the previous PR #268 passed (we looked and the ci/environment used an even older version of matplotlib, which is why all tests passed. We don't know why it used an older matplotlib version though, but that is a separate issue).
This PR also unpins xarray, since tests ran fine within the new
oceanspy_testenvironment which does not pin xarray . If there is an issue then we can figure out later, but so far all tests passed on my oceanspy_test environment.Lets see if things go well...