Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsample checks #282

Merged
merged 14 commits into from
Dec 7, 2022
Merged

Subsample checks #282

merged 14 commits into from
Dec 7, 2022

Conversation

Mikejmnez
Copy link
Collaborator

This PR addresses issue #281

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #282 (8be8568) into main (6f2f8de) will decrease coverage by 0.15%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   95.11%   94.95%   -0.16%     
==========================================
  Files          10       10              
  Lines        3848     3888      +40     
  Branches      812      822      +10     
==========================================
+ Hits         3660     3692      +32     
- Misses        122      128       +6     
- Partials       66       68       +2     
Flag Coverage Δ
unittests 94.95% <82.60%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/llc_rearrange.py 88.09% <81.39%> (-0.67%) ⬇️
oceanspy/subsample.py 98.04% <100.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Dec 6, 2022

Don't merge yet - might include some extra testing

@Mikejmnez
Copy link
Collaborator Author

I am done with testing. Can be approved or reviewed

Copy link
Collaborator

@asiddi24 asiddi24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@asiddi24 asiddi24 merged commit 98469ed into hainegroup:main Dec 7, 2022
Mikejmnez pushed a commit that referenced this pull request Dec 7, 2022
Mikejmnez pushed a commit that referenced this pull request Dec 8, 2022
@Mikejmnez Mikejmnez mentioned this pull request Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants