Binder environment correct #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikejmnez
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
MaceKuailv and
asiddi24
as code owners
Codecov Report
@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 95.74% 95.69% -0.06%
==========================================
Files 9 9
Lines 3928 3927 -1
Branches 850 843 -7
==========================================
- Hits 3761 3758 -3
Misses 97 97
- Partials 70 72 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mikejmnez
pushed a commit
to Mikejmnez/oceanspy
that referenced
this pull request
Dec 30, 2022
Binder environment correct (hainegroup#304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal changes to #303 -
For some reason the Binder environment got build with an older version of
xesmf(0.6.3), which yields an error like that described in #291 . This PR fixes that by explicitly requiring a newer version than that (not just on the binder).