Additional grid files and removing (for the day) access to velocity data. #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikejmnez
requested review from
malmans2,
renskegelderloos,
ThomasHaine,
MaceKuailv and
asiddi24
as code owners
Codecov Report
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 94.66% 94.62% -0.05%
==========================================
Files 9 9
Lines 3939 3942 +3
Branches 856 857 +1
==========================================
+ Hits 3729 3730 +1
- Misses 134 135 +1
- Partials 76 77 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #323 (grid variables
XU, XV, YU, YVare now available in the grid file). I checked having these grid variables pre-computed significantly speeds up the cutout function when transforming (lazily) the dataset.This PR also removes the velocity fields from the intake catalog. This is only temporary. I am combining all the zarr stores (within each single filedb volume) into a single one (see issue #324) . This is going to take the rest of the day. The final destination where all the data (within a single filedb node) will be stored will be where currently the velocity data lives. For that, and to avoid issues when reading LLC4320 data today, I am removing this entry (velocities) from the catalog.
Once the data has been written into a single zarr store, I will create another PR where I restore the entry associated with the velocities. In that PR (later today) all data will be in a single zarr store.