Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding #17

Closed
lrweck opened this issue Oct 2, 2019 · 3 comments
Closed

Rounding #17

lrweck opened this issue Oct 2, 2019 · 3 comments
Labels

Comments

@lrweck
Copy link

lrweck commented Oct 2, 2019

Hey!

More nitpicking! 😅

Rounding to 1.0, especially on large numbers, makes it look like "out by a factor of X" is relevant.

Maybe when it's close to 1% difference it can tell that statistics are accurate for the expected execution.

image

@mchristofides
Copy link
Collaborator

Thank you! Not nit-picking at all, we'll improve the wording here. Since it will round to 1.0 for anything within 5%, we'll probably use that as the threshold!

@hairybreeches
Copy link
Collaborator

Agreed, this is not nitpicking at all - very useful feedback. I'll get on it after finishing #18

@hairybreeches
Copy link
Collaborator

I've updated this to say "accurate to within 5%" instead of "out by a factor of 1.0". You can check it out on node #2 on example 1:

2019-10-15_14-24-02

This fix was added in commit 335370da82c65a60f4c7defa6f2df3ecf644b7a2, deployed at 14:31 15/10/2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants