New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Problem Syncing Files with Folders that have a trailing period #198
Comments
I tested this case. Seafile doesn't end up with sync error. It just creates a folder without period on Windows. E.g. if I check out "test.", "test" is actually created. Does it sync without problem after you remove the period on Linux? |
I haven't tried modifying the files on Linux yet, however It tends to stop at the folder with the period and claim "sync state transition from merging to 'error': 'Files changed in local folder, skip merge.'." If I remove the folder it goes to the next one that has the issue. How did you make the folder in the test case? http://www.autohotkey.com/board/topic/60416-folder-names-with-a-trailing-dot/ |
I just create the folder on the server directly. That should be the same as creating the folder on Linux. |
This is the stat of the file. The bits about the files keep reappearing over and over again. If I delete the folder and redownload it.. everything will download, but for any update on the server side this will result.
|
We have two possible solutions
@monksy Which solution is good for you? |
Depends on the time span. Are we talking about a short term or long term solution? Short term: I have no issue with renaming the folder.... That would be the easiest and least damage done visually. However I think that its something that there should be a test case for. It looks like the initial retrival works fine, that its an issue with reindexing and recognizing the same file. [These files have not been touched sinced the original download] Where did these files come from: These files were renamed via their metadata. There is a high likely hood to see similar behavior out wtihin the realm of what Seafile may host elsewhere. For the short term, I don't mind renaming, but I think that is something that should be targeted at least for a later release. |
With solution 2, what would happen if linux client creates both dir/a.txt and dir./a.txt ? |
@monksy I agree. Something is wrong in the code or your environment. Perhaps the problem is not caused by folders ended with period. Can we send you a new binary with more debug messages? |
Sure, this time It'll have to be a 64bit Windows binary. [Btw this is on an 2013/4/23 Jiaqiang Xu notifications@github.com
|
[bump, I assume this got lost in the other messages] |
Sorry, the log messages will be included in 1.6.1. We also ignore period-ended files on upload. |
No worries. But what about the files that are already in the repository? 2013/4/26 Jiaqiang Xu notifications@github.com
|
There should be no problem for the files already in. I suspect your problem is not caused by period-ended folders. That's why I add more log messages. |
Sounds good, when there is an update I'll get that and update this with the 2013/4/26 Jiaqiang Xu notifications@github.com
|
@monksy 1.6.1 is available for download now. |
I'm getting the exact same errors after the upgrade. |
That's expected. Can you post your log messages again? |
|
More context is needed. Can you post more lines around the above log messages? |
From start to [manual] stop
|
The file M/MetalMusic/Ride/02 - Ride.mp3 looks strange to me. Its size is changed. If it's a mp3 file, its size should rarely be changed. Can you help check anything unusual for this file? For example, is there a file of the same name but with different cases? |
It is an MP3, and all of the files listed were not changed since the download. There has been a download since these issues started] According to windows I have: |
What's the file size? |
Size: 1.43 MB (1,500,308 bytes) |
Can you send the whole log file to me so that I can see what happened at the beginning? xjqkilling at gmail |
That was the entire log. [Before I started seafile I wiped the log] Were you looking for a log that included the download? |
Yes, something went wrong in the initial download of 'Music' library. |
Sent. |
The upgrade to the 1.6.1 client and redownloading has fixed the issue. However, I am getting a lot of "case conflict" folders and files. |
Good to know that. You can find all of them and rename them properly. |
I have this error with seafile Server 2.2.1 and Client 2.1.2 Mac OS X. Anyone Else? |
I use Windows-Server 6.0.7 and Windows-Client 6.0.4 as well as SeaDrive 0.6.0 and still the folder with the trailing period just don't show up. |
I have a few folders that end with a period. I.e. "Company Inc." This is a legal name for a folder in Linux, but this is not the case in Windows [http://superuser.com/questions/283251/moving-files-out-of-an-illegal-folder-ends-with-a-period-in-xp]
Seafile ends up having a huge issue with this and it fails to Sync. The error message that it keeps giving is: sync state transition from merging to 'error': 'Files changed in local folder, skip merge.'.
As I said before, this issue only shows up in Windows, but not on the Linux client
The text was updated successfully, but these errors were encountered: