Sharing with password and default path broken

[yuyichao]

This seems to be broken by 44459bb templates/share_access_validation.html stops checking whether path is empty and always append a p= parameter, which becomes ?p= when the path is empty.

When the request is submitted.

seahub/seahub/views/repo.py

Lines 254 to 255 in 82f16b9

	req_path = request.GET.get('p', '/')
	if req_path[-1] != '/':

req_path will be '' (not handled by get) since it exists, and it caused a OOB error when trying to access the last character.

I now fixed this locally by changing the request handler into

if req_path == '':
    req_path = '/'
elif req_path[-1] != '/':
    req_path += '/'

and it can probably also be fixed from the template as well. Should ?p= be supported? Sumitting a PR for this should be easy but I don't know which one is the proper fix.

P.S. Is there a way to print out the backtrace when an error happens like this? I end up throwing an error in server_error (500 handler) and got the backtrace in error.log. Is there a better way?

Tested on 7.1.1.

[freeplant]

Fixed in #4529