internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported #2478

erexo · 2022-12-02T19:19:03Z

Ebitengine Version

b3be334

Operating System

Go Version (`go version`)

1.19.1

What steps will reproduce the problem?

A few of my players reported, that while running my game on DirectX the game suddenly and without any observable reason closes. I can't really force them to look deeper on what could cause this, but every player is claiming that they are not doing anything special in particular, and the game will crash after ~5-20 minutes after launching.
There are two distinctive errors and I'm not sure how related they are:

First error reported by 2 players:

FATAL|2022/12/02 17:07:20 glfwwin: wglSwapIntervalEXT failed: The operation completed successfully.
panic({0x8d9140, 0xc0213aa900})
	C:/Program Files/Go/src/runtime/panic.go:884 +0x212
github.com/hajimehoshi/ebiten/v2/internal/glfw.SwapInterval(...)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfw/glfw_windows.go:368
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).updateVsync(0x6640780)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/ui_glfw.go:1390 +0x99
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).update(0x6640780)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/ui_glfw.go:1066 +0xda
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).loop.func2()
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/ui_glfw.go:1120 +0x4a
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop.func1(0xc01e74bcb8?, 0xc01e74bca8?)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/thread/thread.go:54 +0x53
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop(0xc0000081f8)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/thread/thread.go:55 +0x2e
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).Run(0x6640780, {0x62f75a8?, 0xc0091f6f50})
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/run_notsinglethread.go:52 +0x231
github.com/hajimehoshi/ebiten/v2.RunGame({0x62f4d70, 0xc000a08240})
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/run.go:233 +0x9d

EDIT(hajimehoshi): See #2481 for this issue.

Second error/s reported by one player:

FATAL|2022/11/30 22:05:05 directx: ID3D12Device::CreateCommittedResource failed: HANDLE(2289696773)
goroutine 1 [running, locked to thread]:
runtime/debug.Stack()
	C:/Program Files/Go/src/runtime/debug/stack.go:24 +0x65
github.com/erexo/logz.Critical({0xc00d927e78?, 0x61931b0?, 0xc0003da840?})
	C:/Users/Erexo/go/src/github.com/erexo/logz/logz.go:212 +0x65
main.main()
	C:/Users/Erexo/go/src/github.com/erexo/gobia/main.go:87 +0x6c8
	
FATAL|2022/12/02 17:48:51 runtime error: index out of range [0] with length 0
panic({0xf34100, 0xc000127da0})
	C:/Program Files/Go/src/runtime/panic.go:884 +0x212
github.com/hajimehoshi/ebiten/v2/internal/glfwwin._DragQueryFileW(...)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfwwin/api_windows.go:1066
github.com/hajimehoshi/ebiten/v2/internal/glfwwin.windowProc(0x30496, 0x233, 0x201056c0078, 0x0)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfwwin/win32window_windows.go:1175 +0x297b
syscall.SyscallN(0x0?, {0xc0093cf180?, 0x30496?, 0x20?})
	C:/Program Files/Go/src/runtime/syscall_windows.go:557 +0x109
syscall.Syscall6(0x10000ffff?, 0x100000001?, 0x100000008?, 0x100000001?, 0x1000000ae219a?, 0xa8df5f?, 0x0?, 0x0?)
	C:/Program Files/Go/src/runtime/syscall_windows.go:501 +0x50
golang.org/x/sys/windows.(*Proc).Call(0xa8e2a7?, {0xc009375a40?, 0xec9240?, 0xc000203401?})
	C:/Users/Erexo/go/pkg/mod/golang.org/x/sys@v0.2.0/windows/dll_windows.go:178 +0x233
golang.org/x/sys/windows.(*LazyProc).Call(0xc000203440, {0xc009375a40, 0x5, 0x5})
	C:/Users/Erexo/go/pkg/mod/golang.org/x/sys@v0.2.0/windows/dll_windows.go:348 +0x50
github.com/hajimehoshi/ebiten/v2/internal/gamepad._CallWindowProcW(...)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/gamepad/api_desktop_windows.go:163
github.com/hajimehoshi/ebiten/v2/internal/gamepad.(*nativeGamepadsDesktop).wndProc(0x0?, 0x30496, 0x233, 0x201056c0078, 0x0)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/gamepad/gamepad_desktop_windows.go:552 +0x97
syscall.SyscallN(0x7ffeee7de040?, {0xc0093cf9b0?, 0x3?, 0x0?})
	C:/Program Files/Go/src/runtime/syscall_windows.go:557 +0x109
syscall.Syscall(0x4?, 0xc00076a6c0?, 0x6c50340?, 0x0?, 0xc0093cfb98?)
	C:/Program Files/Go/src/runtime/syscall_windows.go:495 +0x3b
golang.org/x/sys/windows.(*Proc).Call(0xa8e2a7?, {0xc009d64288?, 0xec7320?, 0x1?})
	C:/Users/Erexo/go/pkg/mod/golang.org/x/sys@v0.2.0/windows/dll_windows.go:170 +0xae
golang.org/x/sys/windows.(*LazyProc).Call(0xc00022c060, {0xc009d64288, 0x1, 0x1})
	C:/Users/Erexo/go/pkg/mod/golang.org/x/sys@v0.2.0/windows/dll_windows.go:348 +0x50
github.com/hajimehoshi/ebiten/v2/internal/glfwwin._DispatchMessageW(...)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfwwin/api_windows.go:1049
github.com/hajimehoshi/ebiten/v2/internal/glfwwin.platformPollEvents()
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfwwin/win32window_windows.go:2052 +0x174
github.com/hajimehoshi/ebiten/v2/internal/glfwwin.PollEvents(...)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfwwin/window_windows.go:820
github.com/hajimehoshi/ebiten/v2/internal/glfw.PollEvents()
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/glfw/glfw_windows.go:347 +0x27
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).update(0x6c50780)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/ui_glfw.go:1070 +0xeb
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).loop.func2()
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/ui_glfw.go:1120 +0x4a
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop.func1(0xc0093cfcb8?, 0xc0093cfca8?)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/thread/thread.go:54 +0x53
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop(0xc000559170)
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/thread/thread.go:55 +0x2e
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).Run(0x6c50780, {0x69075a8?, 0xc00930d260})
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/internal/ui/run_notsinglethread.go:52 +0x231
github.com/hajimehoshi/ebiten/v2.RunGame({0x6904d70, 0xc0008187b0})
	C:/Users/Erexo/go/src/github.com/erexo/ebiten/run.go:233 +0x9d

EDIT(hajimehoshi): See #2480 for the latter issue.

Only a few players reported those errors, I couldn't get their system specs or directx status, and when they switched to OpenGL everything is working as intended.

What is the expected result?

Game does not crash

What happens instead?

ebiten.RunGame return errors

Anything else you feel useful to add?

As OpenGL is working fine for them and they can play normally, that's the another "I told you" about usefulness of having the ability to switch the engine.

The text was updated successfully, but these errors were encountered:

hajimehoshi · 2022-12-02T19:24:44Z

Thank you for reporting!

Ebitengine Version
b3be334

What about the latest version?

FATAL|2022/12/02 17:07:20 glfwwin: wglSwapIntervalEXT failed: The operation completed successfully.

This seems pretty odd... Isn't this an OpenGL operation? I'll take a look

FATAL|2022/11/30 22:05:05 directx: ID3D12Device::CreateCommittedResource failed: HANDLE(2289696773)

This seems a device lost. Isn't the actual device unstable? TBH I have no idea how to fix this 🤔

erexo · 2022-12-02T19:34:41Z

What about the latest version?

I'll try to upgrade to the latest version during my next client update, but I can't guarantee that those players will be still playing 😄
I do understand that those bugs are quite unique and without any reproducible path, but they were discovered by regular users on production so, I can't really say more

Updates #2478

hajimehoshi · 2022-12-02T19:39:45Z

Fixed the first issue at 15c2fe0.

As this bug seems pretty rare, I will not backport this to v2.4, maybe (and I believe you are using v2.5)

erexo · 2022-12-02T19:41:31Z

thank you! there is no need since I'll just use the HEAD.
Is there anything we can do with those two latter issues?

hajimehoshi · 2022-12-02T19:42:15Z

Hm, I'll take a look further tomorrow. I'm gonna sleep soon..

hajimehoshi · 2022-12-02T19:42:28Z

Is there anything we can do with those two latter issues?

Nothing so far, thanks!

Updates #2478

hajimehoshi · 2022-12-02T19:47:52Z

Fixed the third one. 6a0eb82

This seems serious so I'll backport this.

EDIT: I separated this issue to #2480

Updates #2478

erexo · 2022-12-02T19:50:04Z

you are great, thank you so much! 😊

erexo · 2022-12-02T21:14:58Z

I can confirm that the third one happens whenever I move a file over the game window.
Since I don't use and I'm not planning to use the drag-drop feature, is there any chance to disable it completely? (To not have the dragging cursor)

hajimehoshi · 2022-12-03T04:40:55Z

Since I don't use and I'm not planning to use the drag-drop feature, is there any chance to disable it completely? (To not have the dragging cursor)

This is in #1868

hajimehoshi · 2022-12-03T04:50:02Z

So now the remaining issue is

FATAL|2022/11/30 22:05:05 directx: ID3D12Device::CreateCommittedResource failed: HANDLE(2289696773)
goroutine 1 [running, locked to thread]:
runtime/debug.Stack()
	C:/Program Files/Go/src/runtime/debug/stack.go:24 +0x65
github.com/erexo/logz.Critical({0xc00d927e78?, 0x61931b0?, 0xc0003da840?})
	C:/Users/Erexo/go/src/github.com/erexo/logz/logz.go:212 +0x65
main.main()
	C:/Users/Erexo/go/src/github.com/erexo/gobia/main.go:87 +0x6c8

but, as I have already said, I have no idea how to fix. Probably there is nothing we can do...

hajimehoshi · 2022-12-03T04:50:21Z

@erexo Does this happen when lancuing a game, or during a game?

erexo · 2022-12-03T08:16:39Z

Currently It's hard to say, because the "I was playing for a while and then suddenly the game stops" was probably describing the third panic, but when that player sent me his logs I also discovered this one. There is a good chance that it happened during game launch.

Since I don't use and I'm not planning to use the drag-drop feature, is there any chance to disable it completely? (To not have the dragging cursor)

This is in #1868

So is there an option to disable it?

hajimehoshi · 2022-12-03T09:00:20Z

So is there an option to disable it?

Ebitengine doesn't have a feature of drag and drop so far. We might have a new one in the future, but you can ignore it if you don't use it. I have already fixed the crash anyway.

erexo · 2022-12-04T13:49:44Z

I can confirm that the 2nd error is still viable at 6a0eb82 .
ebiten.RunGame throws an error: directx: ID3D12Device::CreateCommittedResource failed: HANDLE(2289696773) after the game was launched, so the user is able to actually run the game, but after a short while the game just throw this error, consistently. Fortunately the player is able to quickly switch to OpenGL and omit this problem.
I was able to reach one of such players and he was kind enough to share his dxdiag with me:

hajimehoshi · 2022-12-04T16:11:42Z

In the machine, as DX12 is not supported directly, OpenGL should be used. Does this bug still occur with the newest commit?

erexo · 2022-12-04T17:29:26Z

I'm not sure how does it behave on the newest commit (760e6b9), but my HEAD (6a0eb82) was pretty far up and I don't see anything that could affect that situation.
Probably tomorrow I'll update the game, so I can upgrade to the latest commit and let you know

hajimehoshi · 2022-12-05T04:21:40Z

What did you specify EBITENGINE_GRAPHICS_LIBRARY by the way?

erexo · 2022-12-06T13:04:02Z

It was set to "auto", so DirectX was actually used and launched, but during game the game crashes. When it's set to "opengl", it works fine

hajimehoshi · 2022-12-06T13:06:57Z

The latest version should not choose DirectX as Ebitengine tries to choose the feature level 12(#2447), and this machine doesn't seem to support it. Please try the HEAD version.

erexo · 2022-12-06T16:23:42Z

That player tested the game on 760e6b9, and the problem persists.
directx: ID3D12Device::CreateCommittedResource failed: HANDLE(2289696773)
I did not set that new feature level env, and the engine env is set to "auto"

hajimehoshi · 2022-12-06T16:43:46Z

That's pretty odd. This GPU doesn't support the feature level 12, right?

erexo · 2022-12-06T17:13:29Z

dxdiag suggests so, yes

This is still mysterious, but this can happen on some old machines. Updates #2478 Closes #2489

hajimehoshi · 2023-02-15T13:28:08Z

Now Ebitengine supports feature level 11 for DirectX, this should no longer be an issue.

erexo added the bug label Dec 2, 2022

github-actions bot added the os:windows label Dec 2, 2022

hajimehoshi added this to the v2.4.14 milestone Dec 2, 2022

hajimehoshi added a commit that referenced this issue Dec 2, 2022

internal/glfwwin: bug fix: unexpected error at wglSwapIntervalEXT

15c2fe0

Updates #2478

hajimehoshi modified the milestones: v2.4.14, v2.5.0 Dec 2, 2022

hajimehoshi added a commit that referenced this issue Dec 2, 2022

internal/glfwwin: bug fix: crash when dropping a file

6a0eb82

Updates #2478

hajimehoshi modified the milestones: v2.5.0, v2.4.14 Dec 2, 2022

hajimehoshi added a commit that referenced this issue Dec 2, 2022

internal/glfwwin: bug fix: crash when dropping a file

f87504c

Updates #2478

hajimehoshi mentioned this issue Dec 3, 2022

internal/glfwwin: crash when drag & drop a file onto a window on Windows #2480

Closed

10 tasks

hajimehoshi modified the milestones: v2.4.14, v2.5.0 Dec 3, 2022

hajimehoshi mentioned this issue Dec 3, 2022

internal/glfwwin: mysterious error from wglSwapIntervalEXT #2481

Closed

10 tasks

hajimehoshi removed this from the v2.5.0 milestone Dec 3, 2022

hajimehoshi changed the title ~~Random ebitengine crash on DirectX~~ internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported Dec 7, 2022

hajimehoshi added the needs-investigation label Dec 7, 2022

erexo mentioned this issue Dec 7, 2022

internal/glfwwin: OpenGL panics #2489

Closed

10 tasks

hajimehoshi added a commit that referenced this issue Dec 8, 2022

internal/glfwwin: ignore an error ERROR_SUCCESS for all Windows APIs

8a95b1d

This is still mysterious, but this can happen on some old machines. Updates #2478 Closes #2489

erexo mentioned this issue Dec 21, 2022

internal/graphicsdriver/directx: unstable performance (sometimes suspending) with DirectX #2485

Closed

10 tasks

hajimehoshi closed this as completed Feb 15, 2023

hajimehoshi removed the needs-investigation label Feb 15, 2023

hajimehoshi added this to the v2.5.0 milestone Feb 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported #2478

internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported #2478

erexo commented Dec 2, 2022 •

edited by hajimehoshi

hajimehoshi commented Dec 2, 2022

erexo commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022 •

edited

erexo commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022 •

edited

erexo commented Dec 2, 2022

erexo commented Dec 2, 2022

hajimehoshi commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022

erexo commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022 •

edited

erexo commented Dec 4, 2022

hajimehoshi commented Dec 4, 2022

erexo commented Dec 4, 2022 •

edited

hajimehoshi commented Dec 5, 2022

erexo commented Dec 6, 2022

hajimehoshi commented Dec 6, 2022

erexo commented Dec 6, 2022 •

edited

hajimehoshi commented Dec 6, 2022

erexo commented Dec 6, 2022

hajimehoshi commented Feb 15, 2023

internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported #2478

internal/graphicsdriver/directx: DirectX can be unexpectedly chosen even when the feature level 12 is not supported #2478

Comments

erexo commented Dec 2, 2022 • edited by hajimehoshi

Ebitengine Version

Operating System

Go Version (go version)

What steps will reproduce the problem?

What is the expected result?

What happens instead?

Anything else you feel useful to add?

hajimehoshi commented Dec 2, 2022

erexo commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022 • edited

erexo commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022

hajimehoshi commented Dec 2, 2022 • edited

erexo commented Dec 2, 2022

erexo commented Dec 2, 2022

hajimehoshi commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022

erexo commented Dec 3, 2022

hajimehoshi commented Dec 3, 2022 • edited

erexo commented Dec 4, 2022

hajimehoshi commented Dec 4, 2022

erexo commented Dec 4, 2022 • edited

hajimehoshi commented Dec 5, 2022

erexo commented Dec 6, 2022

hajimehoshi commented Dec 6, 2022

erexo commented Dec 6, 2022 • edited

hajimehoshi commented Dec 6, 2022

erexo commented Dec 6, 2022

hajimehoshi commented Feb 15, 2023

erexo commented Dec 2, 2022 •

edited by hajimehoshi

Go Version (`go version`)

hajimehoshi commented Dec 2, 2022 •

edited

hajimehoshi commented Dec 2, 2022 •

edited

hajimehoshi commented Dec 3, 2022 •

edited

erexo commented Dec 4, 2022 •

edited

erexo commented Dec 6, 2022 •

edited