Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: all plugins (regardless of target) render in Drawer on small screens #1193

Closed
jacobwod opened this issue Sep 29, 2022 · 1 comment · Fixed by #1194
Closed

Proposal: all plugins (regardless of target) render in Drawer on small screens #1193

jacobwod opened this issue Sep 29, 2022 · 1 comment · Fixed by #1194
Assignees
@jacobwod
Labels
module:client/core Core functionality (not a plugin) needs discussion
Milestone
3.11

Comments

@jacobwod
Copy link
Member

Currently Hajk can be configured in such a way that the number of control buttons (i.e. plugins where target: "control" is set) is so big that we run out of vertical space. See also #1171 where this issue first materialised, especially here.

I propose a change of current functionality that mimics what we currently do with Widget buttons: on small viewports we "move" those buttons from their normal position into the Drawer (sidebar panel).

I think this should be done for control buttons too.
@jacobwod jacobwod added module:client/core Core functionality (not a plugin) needs discussion labels Sep 29, 2022
@jacobwod jacobwod added this to the 3.x milestone Sep 29, 2022
@jacobwod jacobwod self-assigned this Sep 29, 2022
jacobwod added a commit that referenced this issue Sep 29, 2022
@jacobwod
Control buttons render in Drawer on small screens, closes #1193.
0999b84
@jacobwod
Copy link
Member Author

Before and after

In this case there are just two plugins that get moved, but you can still see that we "win back" some screen estate.

Skärmavbild 2022-09-29 kl 13 17 07
Skärmavbild 2022-09-29 kl 13 16 56

@jacobwod jacobwod linked a pull request Oct 19, 2022 that will close this issue
Control buttons render in Drawer on small screens, closes #1193. #1194
Merged
@jacobwod jacobwod modified the milestones: 3.x, 3.11 Oct 19, 2022
jacobwod added a commit that referenced this issue Dec 19, 2022
@jacobwod
Fixed a regression introduced in d7971bd (#1193) - plugins with targe…
fd18477 
…t=hidden should never render in Drawer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobwod jacobwod

Labels
module:client/core Core functionality (not a plugin) needs discussion
Projects
None yet
Milestone
3.11
Development

Successfully merging a pull request may close this issue.

Control buttons render in Drawer on small screens, closes #1193. hajkmap/Hajk
1 participant
@jacobwod