Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DocumentHandler 2.0 - Large images with width and height set breaks view. #1314

Closed
jesade-vbg opened this issue Apr 5, 2023 · 1 comment
Closed

DocumentHandler 2.0 - Large images with width and height set breaks view. #1314

jesade-vbg opened this issue Apr 5, 2023 · 1 comment
Assignees
@jesade-vbg
Labels
bug plugin:documenthandler
Milestone
3.13

Comments

@jesade-vbg
Copy link
Contributor

Today, both width and height is set. If an image is too large... the view wont look good.

Sollution:
Only width should be set, then height will be calculated by the browser.
And the fail safe should be to add maxWidth: 100%. This is the common way to handle it using css.
@jesade-vbg jesade-vbg added this to the 3.12 milestone Apr 5, 2023
@jesade-vbg jesade-vbg self-assigned this Apr 5, 2023
@jesade-vbg jesade-vbg added the bug label Apr 5, 2023
@jesade-vbg jesade-vbg mentioned this issue Apr 5, 2023
Merged
jesade-vbg added a commit that referenced this issue Apr 12, 2023
@jesade-vbg
Merge pull request #1315 from hajkmap/fix/1314-dh2.0-large-images-bre…
8396fdd 
…aks-view

Fix that closes #1314 -dh2.0-large-images-breaks-view
jesade-vbg added a commit that referenced this issue Sep 8, 2023
@jesade-vbg
Revert "Fix that closes #1314 -dh2.0-large-images-breaks-view"
905a046 
This reverts commit 76145cb.
@jesade-vbg jesade-vbg modified the milestones: 3.12, 3.x Sep 8, 2023
@jesade-vbg
Copy link
Contributor Author

Heavy impact... Last minute bug reports.. Reverted in rc 3.12. Maybe revisit in 3.13

@jesade-vbg jesade-vbg reopened this Sep 8, 2023
@jacobwod jacobwod modified the milestones: 3.x, 3.13 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesade-vbg jesade-vbg

Labels
bug plugin:documenthandler
Projects
Hajk
Status: Done
Milestone
3.13
Development

No branches or pull requests
2 participants
@jacobwod @jesade-vbg