Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad contrast on abort and close buttons in Dialog component #854

Closed
Hallbergs opened this issue Aug 31, 2021 · 0 comments
Closed

Bad contrast on abort and close buttons in Dialog component #854

Hallbergs opened this issue Aug 31, 2021 · 0 comments
Assignees
Labels
module:client/core Core functionality (not a plugin)
Milestone

Comments

@Hallbergs
Copy link
Member

General
The dialog-component is using color="primary" on the close and abort buttons, causing bad contrast in when dark-mode is activated, see image:

image

Also, the buttons are auto-focused. I'm not sure why this is, and in my opinion they should not be.

To Reproduce
Open a dialog, for example the search-settings, when dark-mode is activated.

Fix
The fix is simple, and shouldn't lead to any side-effects (as long as i am not missing something critical):

  • remove color="primary" and autoFocus on the buttons in the Dialog component (new-client/src/components/Dialog.js)

image

@Hallbergs Hallbergs added this to the 3.x milestone Aug 31, 2021
@Hallbergs Hallbergs self-assigned this Aug 31, 2021
Hallbergs added a commit that referenced this issue Aug 31, 2021
@Hallbergs Hallbergs modified the milestones: 3.x, 3.8 Sep 16, 2021
@jacobwod jacobwod added the module:client/core Core functionality (not a plugin) label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:client/core Core functionality (not a plugin)
Projects
None yet
Development

No branches or pull requests

2 participants