Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maplinks in the preset-control ignores background layers. #859

Closed
Hallbergs opened this issue Sep 8, 2021 · 0 comments
Closed

Maplinks in the preset-control ignores background layers. #859

Hallbergs opened this issue Sep 8, 2021 · 0 comments
Assignees
Labels
bug module:client/plugin Functionality that goes into plugins in client
Milestone

Comments

@Hallbergs
Copy link
Member

When activating a preset with a background layer, for example: "?m=map_1&x=148000&y=6398900&z=3&l=1,2,3&clean=false" where id: 3 is a background layer, the background layer is not activated.

The maplink works as expected when opening it in the browser.

To Reproduce

  1. Create a maplink with the anchor-plugin (make sure to create a link with a background layer different from the default one)
  2. Add the maplink to the preset-control
  3. Click the preset
  4. Check if the background layer is changed

Proposed solution
It seems like we are ignoring base layers when toggling which layers to show, see image below:
image

The solution would be to handle the base layers as well, not just filter them from the array of layers to show....

@Hallbergs Hallbergs added this to the 3.x milestone Sep 8, 2021
Hallbergs added a commit that referenced this issue Sep 16, 2021
@Hallbergs Hallbergs self-assigned this Sep 16, 2021
@Hallbergs Hallbergs modified the milestones: 3.x, 3.8 Sep 16, 2021
@jacobwod jacobwod added bug module:client/core Core functionality (not a plugin) module:client/plugin Functionality that goes into plugins in client and removed module:client/core Core functionality (not a plugin) labels Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module:client/plugin Functionality that goes into plugins in client
Projects
None yet
Development

No branches or pull requests

2 participants