-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade UI for Coordinates plugin #1138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, i am glad that the coordinate plugin is getting reworked. The previous UI was not very nice.
There seems to be some issues with this implementation though... See below:
-
Alignment. Would look better to have the buttons centered? With the width set in
simpleMapConfig
we get this appearance:
If for some reason someone want a really wide coordinate plugin, we get this appearance:
To make it look good you have to use a "perfect" width. Not desirable. -
If i click somewhere to see the current coordinate i get the following appearance:
(Un-scrollable, quite hard to use tbh.)
A scroll bar now appears in the window if necessary.
Change design and placement on buttons. Two text buttons are now positioned to the left and two icon buttons are positioned to the right.
On mobile devices, the zoom button was hidden behind the snackbar.
…inates-plugin-ui # Conflicts: # new-client/src/plugins/Coordinates/CoordinatesView.js
Now it looks good! Gj! 😄 |
A few UI improvements have been made for the Coordinates plugin to make it more consistent to the other plugins.
Includes the following changes: