Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UI for Coordinates plugin #1138

Merged
merged 13 commits into from
Aug 29, 2022
Merged

Conversation

linusfj
Copy link
Member

@linusfj linusfj commented Jul 29, 2022

A few UI improvements have been made for the Coordinates plugin to make it more consistent to the other plugins.

Includes the following changes:

  • Button order
  • Buttons fill the viewport width on mobile devices
  • Input fields fill the viewport width on mobile devices
  • Less margin around elements
  • Replace Tables with Grid components
  • Use primary theme color on buttons

Copy link
Member

@Hallbergs Hallbergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, i am glad that the coordinate plugin is getting reworked. The previous UI was not very nice.

There seems to be some issues with this implementation though... See below:

  1. Alignment. Would look better to have the buttons centered? With the width set in simpleMapConfig we get this appearance:
    image
    If for some reason someone want a really wide coordinate plugin, we get this appearance:
    image
    To make it look good you have to use a "perfect" width. Not desirable.

  2. If i click somewhere to see the current coordinate i get the following appearance:
    image
    (Un-scrollable, quite hard to use tbh.)

@Hallbergs Hallbergs linked an issue Aug 4, 2022 that may be closed by this pull request
@Hallbergs Hallbergs linked an issue Aug 4, 2022 that may be closed by this pull request
@linusfj linusfj changed the title Upgrade UI for Coordinates plugin, closes #1114 Upgrade UI for Coordinates plugin, Aug 17, 2022
@linusfj linusfj changed the title Upgrade UI for Coordinates plugin, Upgrade UI for Coordinates plugin Aug 17, 2022
A scroll bar now appears in the window if necessary.
Change design and placement on buttons. Two text buttons are now positioned to the left and two icon buttons are positioned to the right.
@linusfj
Copy link
Member Author

linusfj commented Aug 17, 2022

This is the new design with text buttons to the left and icon buttons to the right:
image

Also, the bug with the scroll bar has been fixed.

@Hallbergs
Copy link
Member

Now it looks good! Gj! 😄

@Hallbergs Hallbergs merged commit 3c57fc8 into develop Aug 29, 2022
@Hallbergs Hallbergs deleted the feature/1114-coordinates-plugin-ui branch August 29, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinates plugin: UI changes
3 participants