Feature/PrintAttachmentsMerge #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlofSvahnVbg
requested review from
Hallbergs
and removed request for
sweco-secoma
Hallbergs
requested changes
Apr 17, 2023
There was a problem hiding this comment.
Remove warnings please:
Seems like there are two identical functions!
I see that there are some style-changes to the print-window. Is this print-button move desired? (Moving the button from the bottom to the middle-ish).
Before (In 3.11 at least, maybe this was introduced somewhere else?):
In the PR:
Comment on lines
906
to
909
| toggleDocumentsAttachments = () => { | ||
| let showAttachments = this.state.showAttachments; | ||
| this.setState({ showAttachments: !showAttachments }); | ||
| }; |
There was a problem hiding this comment.
This could lead to some state-timing issues, i would suggest:
this.setState((prevState) => ({ showAttachments: !prevState.showAttachments }));There was a problem hiding this comment.
Hmm, I think the print button move is a remnant from my previous change, can revert it.
I'll fix the other two things. :)
…actored logic for toggling attachments
Hallbergs
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch created solely for merging the relevant changes made in #1289 (DocumentHandler - PrintAttachments). There was some code overlap with another branch that has already been merged.
closes #1289